]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
hw/mips/mips_malta: don't make bios region 'nomigrate'
authorPeter Maydell <peter.maydell@linaro.org>
Mon, 4 Jun 2018 11:03:58 +0000 (12:03 +0100)
committerAleksandar Markovic <amarkovic@wavecomp.com>
Wed, 27 Jun 2018 18:11:46 +0000 (20:11 +0200)
Currently we use memory_region_init_rom_nomigrate() to create
the "bios.1fc" memory region, and we don't manually register
it with vmstate_register_ram(). This currently means that its
contents are migrated but as a ram block whose name is the empty
string; in future it may mean they are not migrated at all. Use
memory_region_init_ram() instead.

Note that this is a a cross-version migration compatibility break
for the "malta" machine.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Paul Burton <paul.burton@mips.com>
Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
hw/mips/mips_malta.c

index 494f84e2900c5de8ed0a92eaa4198fca35aaea12..b9d92bf47e052e153d4803c05b30a09831f546f6 100644 (file)
@@ -1152,7 +1152,7 @@ void mips_malta_init(MachineState *machine)
      * handled by an overlapping region as the resulting ROM code subpage
      * regions are not executable.
      */
-    memory_region_init_ram_nomigrate(bios_copy, NULL, "bios.1fc", BIOS_SIZE,
+    memory_region_init_ram(bios_copy, NULL, "bios.1fc", BIOS_SIZE,
                            &error_fatal);
     if (!rom_copy(memory_region_get_ram_ptr(bios_copy),
                   FLASH_ADDRESS, BIOS_SIZE)) {