]> xenbits.xensource.com Git - libvirt.git/commitdiff
Use qemuDomainMachineIs helpers when adding default devices
authorJán Tomko <jtomko@redhat.com>
Tue, 3 May 2016 08:33:56 +0000 (10:33 +0200)
committerJán Tomko <jtomko@redhat.com>
Tue, 3 May 2016 10:07:45 +0000 (12:07 +0200)
Do not duplicate the string comparisons by writing them twice.

src/qemu/qemu_domain.c

index 3f1fbd7330e4e31c5ded36251c71f11116f6cd66..c17abbb2d3d5e1fd1d69a2eecf188e5c6220dc3b 100644 (file)
@@ -1740,8 +1740,7 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr def,
             addDefaultUSB = false;
             break;
         }
-        if (STRPREFIX(def->os.machine, "pc-q35") ||
-            STREQ(def->os.machine, "q35")) {
+        if (qemuDomainMachineIsQ35(def)) {
             addPCIeRoot = true;
             addImplicitSATA = true;
 
@@ -1754,11 +1753,7 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr def,
                 addDefaultUSB = false;
             break;
         }
-        if (!STRPREFIX(def->os.machine, "pc-0.") &&
-            !STRPREFIX(def->os.machine, "pc-1.") &&
-            !STRPREFIX(def->os.machine, "pc-i440") &&
-            STRNEQ(def->os.machine, "pc") &&
-            !STRPREFIX(def->os.machine, "rhel"))
+        if (!qemuDomainMachineIsI440FX(def))
             break;
         addPCIRoot = true;
         break;