]> xenbits.xensource.com Git - people/iwj/osstest.git/commitdiff
db retry: Document $@ as an implicit parameter to need_retry
authorIan Jackson <ian.jackson@eu.citrix.com>
Tue, 20 Dec 2016 17:09:09 +0000 (17:09 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 20 Dec 2016 17:36:06 +0000 (17:36 +0000)
There are only two call sites and neither trashes $@ right now.
We are going to use a more exception-friendly style.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Osstest/JobDB/Executive.pm

index 7eeaf52afb40ba52b1f847b202eb489e50437dfa..ebafb4c3bd848877e6646b8302779397d7e33c46 100644 (file)
@@ -59,7 +59,7 @@ sub begin_work ($$$) { #method
 }
 
 sub need_retry ($$$) {
-    my ($jd, $dbh,$committing) = @_;
+    my ($jd, $dbh,$committing) = @_; # implicitly, $@ is an argument too
     return
        ($dbh_tests->err() // 0)==7 &&
        ($dbh_tests->state =~ m/^(?:40P01|40001|23|40002)/);