]> xenbits.xensource.com Git - people/andrewcoop/seabios.git/commitdiff
smm: fix outl argument order
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 27 Jul 2015 10:23:58 +0000 (12:23 +0200)
committerKevin O'Connor <kevin@koconnor.net>
Thu, 30 Jul 2015 15:32:04 +0000 (11:32 -0400)
The value is the first argument and the port is the second, but the code
was using the opposite order.

Reported-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
src/fw/smm.c

index 6cb484e7e579d7f01ce6fa0322e73f605fa78f99..5145f145b5e981d44e36c507b0a3fda8927eea9b 100644 (file)
@@ -184,7 +184,7 @@ static void piix4_apmc_smm_setup(int isabdf, int i440_bdf)
 
     /* enable SMI generation */
     value = inl(acpi_pm_base + PIIX_PMIO_GLBCTL);
-    outl(acpi_pm_base + PIIX_PMIO_GLBCTL, value | PIIX_PMIO_GLBCTL_SMI_EN);
+    outl(value | PIIX_PMIO_GLBCTL_SMI_EN, acpi_pm_base + PIIX_PMIO_GLBCTL);
 
     smm_relocate_and_restore();