]> xenbits.xensource.com Git - people/aperard/qemu-dm.git/commitdiff
accel/tcg: Check for USER_ONLY definition instead of SOFTMMU one
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 13 Jun 2023 13:33:44 +0000 (15:33 +0200)
committerRichard Henderson <richard.henderson@linaro.org>
Tue, 20 Jun 2023 08:01:30 +0000 (10:01 +0200)
Since we *might* have user emulation with softmmu,
replace the system emulation check by !user emulation one.

Invert some if() ladders for clarity.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230613133347.82210-7-philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
accel/tcg/cpu-exec.c
accel/tcg/internal.h

index ebc1db03d73eccb19f4e3b4a0eca67cfb0d5a0d4..c0ab00385f4165e0f5999122ca0533dd023a5c49 100644 (file)
@@ -566,7 +566,7 @@ void cpu_exec_step_atomic(CPUState *cpu)
         cpu_tb_exec(cpu, tb, &tb_exit);
         cpu_exec_exit(cpu);
     } else {
-#ifndef CONFIG_SOFTMMU
+#ifdef CONFIG_USER_ONLY
         clear_helper_retaddr();
         if (have_mmap_lock()) {
             mmap_unlock();
@@ -1023,7 +1023,7 @@ static int cpu_exec_setjmp(CPUState *cpu, SyncClocks *sc)
         /* Non-buggy compilers preserve this; assert the correct value. */
         g_assert(cpu == current_cpu);
 
-#ifndef CONFIG_SOFTMMU
+#ifdef CONFIG_USER_ONLY
         clear_helper_retaddr();
         if (have_mmap_lock()) {
             mmap_unlock();
index 24f225cac7e9ea9dd53c79966b8fbb7984234d5d..65380ccb427912af742d0d4f31b0c1b2cd25b1b9 100644 (file)
  * memory related structures are protected with mmap_lock.
  * In !user-mode we use per-page locks.
  */
-#ifdef CONFIG_SOFTMMU
-#define assert_memory_lock()
-#else
+#ifdef CONFIG_USER_ONLY
 #define assert_memory_lock() tcg_debug_assert(have_mmap_lock())
+#else
+#define assert_memory_lock()
 #endif
 
 #if defined(CONFIG_SOFTMMU) && defined(CONFIG_DEBUG_TCG)