]> xenbits.xensource.com Git - libvirt.git/commitdiff
virsh: improve the error for wrong memtune parameters
authorShanzhi Yu <shyu@redhat.com>
Tue, 14 Apr 2015 10:24:40 +0000 (18:24 +0800)
committerJán Tomko <jtomko@redhat.com>
Tue, 14 Apr 2015 11:48:29 +0000 (13:48 +0200)
When set guest memory with a invalid parameter of --soft-limit,
it posts weird error:

$ virsh memtune r7 --hard-limit 20417224 --soft-limit 9007199254740992 \
  --swap-hard-limit 35417224
error: Unable to parse integer parameter 'NAME

Change it to

error: Unable to parse integer parameter soft-limit

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1211550
Signed-off-by: Shanzhi Yu <shyu@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
tools/virsh-domain.c

index 3e2c420d3b142e7b5d8ce9450607d621fb41e4de..bc6054ad39b4644ff8929b00a46aabc48d0aff3c 100644 (file)
@@ -8417,7 +8417,7 @@ cmdMemtune(vshControl *ctl, const vshCmd *cmd)
 
 #define PARSE_MEMTUNE_PARAM(NAME, FIELD)                                    \
     if ((rc = vshMemtuneGetSize(cmd, NAME, &tmpVal)) < 0) {                 \
-        vshError(ctl, "%s", _("Unable to parse integer parameter 'NAME'")); \
+        vshError(ctl, _("Unable to parse integer parameter %s"), NAME);     \
         goto cleanup;                                                       \
     }                                                                       \
     if (rc == 1) {                                                          \