]> xenbits.xensource.com Git - libvirt.git/commitdiff
Cleanup virBuffer usage in qemdBuildCommandLine
authorMatthew Booth <mbooth@redhat.com>
Fri, 6 Nov 2009 11:19:21 +0000 (12:19 +0100)
committerDaniel Veillard <veillard@redhat.com>
Fri, 6 Nov 2009 11:19:21 +0000 (12:19 +0100)
* src/qemu_qemu_conf.c: Cleanup usage of virBuffer in qemudBuildCommandLine

src/qemu/qemu_conf.c

index f010f4a75cc0d134b83bd9fceced7b2841baec79..4a278e3d8e59b83132725f465281550731e6124d 100644 (file)
@@ -2182,7 +2182,6 @@ int qemudBuildCommandLine(virConnectPtr conn,
 
     for (i = 0 ; i < def->nchannels ; i++) {
         virBuffer buf = VIR_BUFFER_INITIALIZER;
-        const char *argStr;
         char id[16];
 
         virDomainChrDefPtr channel = def->channels[i];
@@ -2199,24 +2198,18 @@ int qemudBuildCommandLine(virConnectPtr conn,
             }
 
             qemudBuildCommandLineChrDevChardevStr(channel, id, &buf);
-            argStr = virBufferContentAndReset(&buf);
-            if (argStr == NULL)
+            if (virBufferError(&buf))
                 goto error;
 
             ADD_ARG_LIT("-chardev");
-            ADD_ARG_LIT(argStr);
-
-            VIR_FREE(argStr);
+            ADD_ARG(virBufferContentAndReset(&buf));
 
             qemudBuildCommandLineChrDevTargetStr(channel, id, &buf);
-            argStr = virBufferContentAndReset(&buf);
-            if (argStr == NULL)
+            if (virBufferError(&buf))
                 goto error;
 
             ADD_ARG_LIT("-net");
-            ADD_ARG_LIT(argStr);
-
-            VIR_FREE(argStr);
+            ADD_ARG(virBufferContentAndReset(&buf));
         }
     }