]> xenbits.xensource.com Git - libvirt.git/commitdiff
tests: libxl: Fix a segfault when libxl configuration setup fails
authorJulio Faracco <jcfaracco@gmail.com>
Thu, 2 Aug 2018 04:06:39 +0000 (01:06 -0300)
committerErik Skultety <eskultet@redhat.com>
Thu, 2 Aug 2018 08:35:35 +0000 (10:35 +0200)
This commit fixes a segmentation fault caused by missing conditional to
check if libxl configuration was properly created by the test. If the
configuration was not properly created, libxlDriverConfigNew() function
will return NULL and cause a segfault at cfg->caps = NULL during the
cleanup.

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
tests/libxlxml2domconfigtest.c

index 34a63e22b547fda5250ef464927fdc0fa1a67016..a9758c40cbb04cdf80e7daab992fcb5a14df07b9 100644 (file)
@@ -138,7 +138,8 @@ testCompareXMLToDomConfig(const char *xmlfile,
     libxl_domain_config_dispose(&actualconfig);
     libxl_domain_config_dispose(&expectconfig);
     xtl_logger_destroy(log);
-    cfg->caps = NULL;
+    if (cfg)
+        cfg->caps = NULL;
     virObjectUnref(cfg);
     return ret;
 }