]> xenbits.xensource.com Git - libvirt.git/commitdiff
Fix qemu-nbd cleanup crashes
authorCédric Bosdonnat <cbosdonnat@suse.com>
Wed, 15 Jul 2015 07:58:18 +0000 (09:58 +0200)
committerCédric Bosdonnat <cbosdonnat@suse.com>
Wed, 15 Jul 2015 08:16:14 +0000 (10:16 +0200)
The virLXCControllerAppendNBDPids function didn't properly initialize
pids and npids. In case of failure it was crashing when freeing those.

src/lxc/lxc_controller.c

index 27e2e3a85a17682efde81c37da01668ea45275f5..c73bb4f58092a3b2f508f5756319292832e7c72f 100644 (file)
@@ -533,8 +533,8 @@ static int virLXCControllerAppendNBDPids(virLXCControllerPtr ctrl,
                                          const char *dev)
 {
     char *pidpath = NULL;
-    pid_t *pids;
-    size_t npids;
+    pid_t *pids = NULL;
+    size_t npids = 0;
     size_t i;
     int ret = -1;
     pid_t pid;