]> xenbits.xensource.com Git - libvirt.git/commitdiff
rpc: avoid null deref
authorEric Blake <eblake@redhat.com>
Tue, 2 Aug 2011 21:57:19 +0000 (15:57 -0600)
committerEric Blake <eblake@redhat.com>
Tue, 2 Aug 2011 22:39:01 +0000 (16:39 -0600)
Detected by Coverity.

* src/rpc/virnetserverclient.c (virNetServerClientDispatchRead):
Avoid null deref on OOM.

src/rpc/virnetserverclient.c

index 2f6c04076261ed920181a7520a60b85be6aa362b..e246fa54c2ee98ba32ac14787c815cdea1dfa2dc 100644 (file)
@@ -786,9 +786,10 @@ readmore:
         if (client->nrequests < client->nrequests_max) {
             if (!(client->rx = virNetMessageNew())) {
                 client->wantClose = true;
+            } else {
+                client->rx->bufferLength = VIR_NET_MESSAGE_LEN_MAX;
+                client->nrequests++;
             }
-            client->rx->bufferLength = VIR_NET_MESSAGE_LEN_MAX;
-            client->nrequests++;
         }
         virNetServerClientUpdateEvent(client);
     }