]> xenbits.xensource.com Git - people/iwj/xen.git/commitdiff
x86/iommu: fix wrong usage of iommu_hwdom_inclusive
authorRoger Pau Monné <roger.pau@citrix.com>
Tue, 2 Oct 2018 15:01:41 +0000 (17:01 +0200)
committerJan Beulich <jbeulich@suse.com>
Tue, 2 Oct 2018 15:01:41 +0000 (17:01 +0200)
iommu_hwdom_inclusive was used where iommu_hwdom_reserved should be
used.

Reported-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
xen/drivers/passthrough/iommu.c
xen/drivers/passthrough/x86/iommu.c

index ae6cf2f0ffd57b5af02188f028776e71421412a3..8f4309760a642b78f0501d761f83f1f2a9d1cb59 100644 (file)
@@ -157,7 +157,7 @@ static int __init parse_dom0_iommu_param(const char *s)
         else if ( (val = parse_boolean("map-inclusive", s, ss)) >= 0 )
             iommu_hwdom_inclusive = val;
         else if ( (val = parse_boolean("map-reserved", s, ss)) >= 0 )
-            iommu_hwdom_inclusive = val;
+            iommu_hwdom_reserved = val;
         else
             rc = -EINVAL;
 
index b7c8b5be41da41a4cc18d19964d05423cf0eb418..69e45b8e00428a2727f016df117e3b2b476bc3a0 100644 (file)
@@ -210,7 +210,7 @@ void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
 
     BUG_ON(!is_hardware_domain(d));
 
-    ASSERT(iommu_hwdom_inclusive != -1 && iommu_hwdom_inclusive != -1);
+    ASSERT(iommu_hwdom_inclusive != -1 && iommu_hwdom_reserved != -1);
     if ( iommu_hwdom_inclusive && !is_pv_domain(d) )
     {
         printk(XENLOG_WARNING