]> xenbits.xensource.com Git - xen.git/commitdiff
x86: compat_show_guest_stack() should not truncate MFN
authorJan Beulich <jbeulich@suse.com>
Thu, 17 Jan 2013 14:19:41 +0000 (15:19 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 17 Jan 2013 14:19:41 +0000 (15:19 +0100)
Re-using "addr" here was a mistake, as it is a 32-bit quantity.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Keir Fraser <keir@xen.org>
xen-unstable changeset: 26332:8e942f2f3b45
xen-unstable date: Mon Jan  7 12:28:29 UTC 2013

xen/arch/x86/x86_64/compat/traps.c

index a9ee983a903d71b544b91350ec2907cf93237de1..4a4b1b75c7156143f3c3a806d5b9a98df8d3090e 100644 (file)
@@ -20,11 +20,12 @@ void compat_show_guest_stack(struct vcpu *v, struct cpu_user_regs *regs,
     if ( v != current )
     {
         struct vcpu *vcpu;
+        unsigned long mfn;
 
         ASSERT(guest_kernel_mode(v, regs));
-        addr = read_cr3() >> PAGE_SHIFT;
+        mfn = read_cr3() >> PAGE_SHIFT;
         for_each_vcpu( v->domain, vcpu )
-            if ( pagetable_get_pfn(vcpu->arch.guest_table) == addr )
+            if ( pagetable_get_pfn(vcpu->arch.guest_table) == mfn )
                 break;
         if ( !vcpu )
         {