]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
tests/avocado: Cancel BootLinux tests in case there is no free port
authorThomas Huth <thuth@redhat.com>
Mon, 28 Feb 2022 11:43:25 +0000 (12:43 +0100)
committerThomas Huth <thuth@redhat.com>
Mon, 7 Mar 2022 17:59:44 +0000 (18:59 +0100)
The BootLinux tests are currently failing with an ugly python
stack trace on my RHEL8 system since they cannot get a free port
(likely due to the firewall settings on my system). Let's properly
check the return value of find_free_port() instead and cancel the
test gracefully if it cannot get a free port.

Message-Id: <20220228114325.818294-1-thuth@redhat.com>
Reviewed-by: Beraldo Leal <bleal@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/avocado/avocado_qemu/__init__.py

index 75063c0c30102c38393905ffb5e8db2a60074e62..9b056b5ce5d2d25c199bbf8124400fa2a8dd01a9 100644 (file)
@@ -603,6 +603,8 @@ class LinuxTest(LinuxSSHMixIn, QemuSystemTest):
         try:
             cloudinit_iso = os.path.join(self.workdir, 'cloudinit.iso')
             self.phone_home_port = network.find_free_port()
+            if not self.phone_home_port:
+                self.cancel('Failed to get a free port')
             pubkey_content = None
             if ssh_pubkey:
                 with open(ssh_pubkey) as pubkey: