]> xenbits.xensource.com Git - libvirt.git/commitdiff
vbox: Drop @iid from UIMachine::LaunchVMProcess()
authorMichal Privoznik <mprivozn@redhat.com>
Sun, 22 Jan 2023 11:30:02 +0000 (12:30 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 24 Jan 2023 09:23:51 +0000 (10:23 +0100)
The @iid argument of UIMachine::LaunchVMProcess() callback is
unused. Drop it and also its propagation from parent functions.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/vbox/vbox_common.c
src/vbox/vbox_tmpl.c
src/vbox/vbox_uniformed_api.h

index 6f32a395af253a5abb7d5cc177fbaffaf8a284b4..24cdd6eeb946c585a0d8516beca116e528c621a1 100644 (file)
@@ -2046,7 +2046,7 @@ static int vboxDomainUndefine(virDomainPtr dom)
 }
 
 static int
-vboxStartMachine(virDomainPtr dom, int maxDomID, IMachine *machine, vboxIID *iid)
+vboxStartMachine(virDomainPtr dom, int maxDomID, IMachine *machine)
 {
     struct _vboxDriver *data = dom->conn->privateData;
     int vrdpPresent = 0;
@@ -2148,7 +2148,7 @@ vboxStartMachine(virDomainPtr dom, int maxDomID, IMachine *machine, vboxIID *iid
         VBOX_UTF8_TO_UTF16("vrdp", &sessionType);
     }
 
-    rc = gVBoxAPI.UIMachine.LaunchVMProcess(data, machine, iid,
+    rc = gVBoxAPI.UIMachine.LaunchVMProcess(data, machine,
                                             sessionType, env,
                                             &progress);
 
@@ -2239,7 +2239,7 @@ static int vboxDomainCreateWithFlags(virDomainPtr dom, unsigned int flags)
                 gVBoxAPI.UIMachine.GetState(machine, &state);
 
                 if (gVBoxAPI.machineStateChecker.NotStart(state)) {
-                    ret = vboxStartMachine(dom, i, machine, &iid);
+                    ret = vboxStartMachine(dom, i, machine);
                 } else {
                     virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                                    _("machine is not in "
index fa9906e0c7f3c08222e38153b04fdb401a0f174b..8f7a2a6512cab84cf3fbb158b43371d54dbe7ec3 100644 (file)
@@ -747,7 +747,6 @@ _machineRemoveSharedFolder(IMachine *machine, PRUnichar *name)
 static nsresult
 _machineLaunchVMProcess(struct _vboxDriver *data,
                         IMachine *machine,
-                        vboxIID *iid G_GNUC_UNUSED,
                         PRUnichar *sessionType, PRUnichar *env,
                         IProgress **progress)
 {
index 18f352d98e221c1f2c888e4a33e5eb0ca217a287..393e48827fd5a75350a607c878f4ac6d0abaf3e7 100644 (file)
@@ -182,7 +182,6 @@ typedef struct {
                                    PRBool automount);
     nsresult (*RemoveSharedFolder)(IMachine *machine, PRUnichar *name);
     nsresult (*LaunchVMProcess)(struct _vboxDriver *driver, IMachine *machine,
-                                vboxIID *iid,
                                 PRUnichar *sessionType, PRUnichar *env,
                                 IProgress **progress);
     nsresult (*Unregister)(IMachine *machine, PRUint32 cleanupMode,