]> xenbits.xensource.com Git - people/iwj/osstest.git/commitdiff
support check: Style improvements - rename _check_for_command
authorIan Jackson <ian.jackson@eu.citrix.com>
Fri, 14 Oct 2016 14:37:11 +0000 (15:37 +0100)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Fri, 14 Oct 2016 17:30:39 +0000 (18:30 +0100)
Put an underscore in front.  This is not a public method.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Osstest/Toolstack/libvirt.pm
Osstest/Toolstack/xl.pm

index 2ee8b3c3c969bbb80372ea77f68a0af53678cbcb..45df1734aa208ebf3d8539bc2a53e4f15b9767d5 100644 (file)
@@ -99,7 +99,7 @@ sub migrate_check ($$) {
        ('/capabilities/host/migration_features/live');
 }
 
-sub check_for_command($$) {
+sub _check_for_command($$) {
     my ($self,$cmd) = @_;
     my $ho = $self->{Host};
     my $help = target_cmd_output_root($ho, "virsh help");
@@ -110,7 +110,7 @@ sub saverestore_check ($) {
     my ($self) = @_;
     return
        _check_capability($self, '/capabilities/host/migration_features') &&
-       check_for_command($self, "save");
+       _check_for_command($self, "save");
 }
 
 sub migrate ($$$$) {
index 6a4a5d790c7364a3359f55a58b0010b0617da414..e179217c83cba1fd7c783c115e823c7c4ec4e823 100644 (file)
@@ -61,7 +61,7 @@ sub shutdown_wait ($$$) {
     target_cmd_root($ho,"$self->{_Command} shutdown -w${acpi_fallback} $gn", $timeout);
 }
 
-sub check_for_command($$) {
+sub _check_for_command($$) {
     my ($self,$cmd) = @_;
     my $ho = $self->{Host};
     my $help = target_cmd_output_root($ho, $self->{_Command}." help");
@@ -70,12 +70,12 @@ sub check_for_command($$) {
 
 sub migrate_check ($$) {
     my ($self,$local) = @_;
-    return check_for_command($self, "migrate");
+    return _check_for_command($self, "migrate");
 }
 
 sub saverestore_check ($) {
     my ($self) = @_;
-    return check_for_command($self, "save");
+    return _check_for_command($self, "save");
 }
 
 sub migrate ($$$$) {