vircommand: Simplify virCommandAddArg

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>

diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index c3a98bbeac20e965a58555f12d86222ae5a9069a..b1a26f68aa87583e4a12dc296cdb86f17d132c03 100644 (file)
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -1520,8 +1520,6 @@ virCommandAddEnvXDG(virCommandPtr cmd, const char *baseDir)
 void
 virCommandAddArg(virCommandPtr cmd, const char *val)
 {
-    char *arg;
-
     if (!cmd || cmd->has_error)
         return;
 
@@ -1530,16 +1528,13 @@ virCommandAddArg(virCommandPtr cmd, const char *val)
         return;
     }
 
-    arg = g_strdup(val);
-
     /* Arg plus trailing NULL. */
     if (VIR_RESIZE_N(cmd->args, cmd->maxargs, cmd->nargs, 1 + 1) < 0) {
-        VIR_FREE(arg);
         cmd->has_error = ENOMEM;
         return;
     }
 
-    cmd->args[cmd->nargs++] = arg;
+    cmd->args[cmd->nargs++] = g_strdup(val);
 }