]> xenbits.xensource.com Git - xen.git/commitdiff
x86/vLAPIC: don't leak regs page from vlapic_init() upon error
authorJan Beulich <jbeulich@suse.com>
Fri, 2 Oct 2020 10:30:34 +0000 (12:30 +0200)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 9 Oct 2020 16:20:11 +0000 (17:20 +0100)
Fixes: 8a981e0bf25e ("Make map_domain_page_global fail")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/hvm/vlapic.c

index 4e3861eb7dd4c304f42dac5f685a899bf6764b8c..59660a8af4c294ae88daea4698c2110c6762bc63 100644 (file)
@@ -1625,6 +1625,7 @@ int vlapic_init(struct vcpu *v)
         vlapic->regs = __map_domain_page_global(vlapic->regs_page);
         if ( vlapic->regs == NULL )
         {
+            free_domheap_page(vlapic->regs_page);
             dprintk(XENLOG_ERR, "map vlapic regs error: %d/%d\n",
                     v->domain->domain_id, v->vcpu_id);
             return -ENOMEM;