]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
conf: Use correct type for device type enum in virDomainDeviceDefFree
authorPeter Krempa <pkrempa@redhat.com>
Thu, 20 Dec 2012 12:41:32 +0000 (13:41 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 5 Feb 2013 14:04:16 +0000 (15:04 +0100)
With this change it's easy to spot a forgotten free if a new device
class is added.

src/conf/domain_conf.c

index abf2b6bcd951b34703edb7e4b6970d833241fc84..de54c2c02ef2add86a49fc83b1e6b6ed01f92cf9 100644 (file)
@@ -1524,7 +1524,7 @@ void virDomainDeviceDefFree(virDomainDeviceDefPtr def)
     if (!def)
         return;
 
-    switch (def->type) {
+    switch ((virDomainDeviceType) def->type) {
     case VIR_DOMAIN_DEVICE_DISK:
         virDomainDiskDefFree(def->data.disk);
         break;
@@ -1561,6 +1561,13 @@ void virDomainDeviceDefFree(virDomainDeviceDefPtr def)
     case VIR_DOMAIN_DEVICE_REDIRDEV:
         virDomainRedirdevDefFree(def->data.redirdev);
         break;
+    case VIR_DOMAIN_DEVICE_NONE:
+    case VIR_DOMAIN_DEVICE_FS:
+    case VIR_DOMAIN_DEVICE_SMARTCARD:
+    case VIR_DOMAIN_DEVICE_CHR:
+    case VIR_DOMAIN_DEVICE_MEMBALLOON:
+    case VIR_DOMAIN_DEVICE_LAST:
+        break;
     }
 
     VIR_FREE(def);