]> xenbits.xensource.com Git - people/vhanquez/xen.git/commitdiff
x86: don't allow Dom0 to map MSI-X table writably
authorJan Beulich <jbeulich@suse.com>
Wed, 15 Feb 2012 11:04:44 +0000 (12:04 +0100)
committerJan Beulich <jbeulich@suse.com>
Wed, 15 Feb 2012 11:04:44 +0000 (12:04 +0100)
With the traditional qemu tree fixed to not use PROT_WRITE anymore in
the mmap() call for this region, and with the upstream qemu tree not
being capable of handling passthrough, yet, there's no need to treat
Dom specially here anymore.

This continues to leave unaddressed the case where PV guests map the
MSI-X table page(s) before setting up the first MSI-X interrupt (see
the original c/s 22182:68cc3c514a0a description for options).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
xen/arch/x86/mm.c

index 120033beebfcfcce3ab1bd60608732ff80538072..ff2ccd95e98b7f5fd9b4d48d1b873f304d9a3823 100644 (file)
@@ -869,7 +869,7 @@ get_page_from_l1e(
             return -EINVAL;
         }
 
-        if ( !(l1f & _PAGE_RW) || IS_PRIV(pg_owner) ||
+        if ( !(l1f & _PAGE_RW) ||
              !rangeset_contains_singleton(mmio_ro_ranges, mfn) )
             return 0;
         dprintk(XENLOG_G_WARNING,