]> xenbits.xensource.com Git - libvirt.git/commitdiff
rpc: protocol: Clarify VIR_NET_ERROR usage with streams
authorCole Robinson <crobinso@redhat.com>
Sun, 24 Apr 2016 20:27:19 +0000 (16:27 -0400)
committerCole Robinson <crobinso@redhat.com>
Mon, 2 May 2016 14:13:04 +0000 (10:13 -0400)
The described protocol semantics really only apply to server initiated
stream messages. Document the semantics for client messages.

src/rpc/virnetprotocol.x

index 327a33475bfd196df533f4418704163a4b06da95..9ce33b0735cb84fdf6bebdf0d2495c0276ce38c8 100644 (file)
@@ -104,7 +104,9 @@ const VIR_NET_MESSAGE_NUM_FDS_MAX = 32;
  *  - type == VIR_NET_STREAM
  *     * VIR_NET_CONTINUE if more data is following
  *     * VIR_NET_OK if stream is complete
- *     * VIR_NET_ERROR if stream had an error
+ *     * VIR_NET_ERROR
+ *         server message: stream had an error
+ *         client message: client aborted the stream
  *
  * Payload varies according to type and status:
  *
@@ -125,7 +127,8 @@ const VIR_NET_MESSAGE_NUM_FDS_MAX = 32;
  *     * status == VIR_NET_CONTINUE
  *          byte[]       raw stream data
  *     * status == VIR_NET_ERROR
- *          remote_error error information
+ *          server message: remote_error error information
+ *          client message: <empty>
  *     * status == VIR_NET_OK
  *          <empty>
  *