]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: fix a crash when save file can't be opened
authorJán Tomko <jtomko@redhat.com>
Wed, 28 Nov 2012 08:08:52 +0000 (09:08 +0100)
committerMartin Kletzander <mkletzan@redhat.com>
Wed, 28 Nov 2012 09:24:31 +0000 (10:24 +0100)
In qemuDomainSaveMemory, wrapperFd might be NULL and should be checked before
calling virFileWrapperFdCatchError. Same in doCoreDump.

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=880919

src/qemu/qemu_driver.c

index c526f5fa4b64c4c8d7e4b7da9b61baaf4167d910..7892293e3296c142e3c8e48730a44250120bd56e 100644 (file)
@@ -2906,7 +2906,8 @@ qemuDomainSaveMemory(struct qemud_driver *driver,
 
 cleanup:
     VIR_FORCE_CLOSE(fd);
-    virFileWrapperFdCatchError(wrapperFd);
+    if (wrapperFd)
+        virFileWrapperFdCatchError(wrapperFd);
     virFileWrapperFdFree(wrapperFd);
     VIR_FREE(xml);
 
@@ -3362,7 +3363,8 @@ doCoreDump(struct qemud_driver *driver,
 cleanup:
     VIR_FORCE_CLOSE(fd);
     if (ret != 0) {
-        virFileWrapperFdCatchError(wrapperFd);
+        if (wrapperFd)
+            virFileWrapperFdCatchError(wrapperFd);
         unlink(path);
     }
     virFileWrapperFdFree(wrapperFd);