]> xenbits.xensource.com Git - people/aperard/xen-unstable.git/commitdiff
xen/arm: smmu: address violations of MISRA C Rule 20.7
authorNicola Vetrini <nicola.vetrini@bugseng.com>
Tue, 19 Mar 2024 10:28:44 +0000 (11:28 +0100)
committerJan Beulich <jbeulich@suse.com>
Tue, 19 Mar 2024 10:28:44 +0000 (11:28 +0100)
MISRA C Rule 20.7 states: "Expressions resulting from the expansion
of macro parameters shall be enclosed in parentheses". Therefore, some
macro definitions should gain additional parentheses to ensure that all
current and future users will be safe with respect to expansions that
can possibly alter the semantics of the passed-in macro parameter.

No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
xen/drivers/passthrough/arm/smmu.c

index 83196057a937b1ef3392778d4e7bd7421a48d431..f2cee82f553aaa28c7757d97b77dcf2a222dfddc 100644 (file)
@@ -326,7 +326,7 @@ static struct iommu_group *iommu_group_get(struct device *dev)
  */
 #define ARM_SMMU_GR0_NS(smmu)                                          \
        ((smmu)->base +                                                 \
-               ((smmu->options & ARM_SMMU_OPT_SECURE_CFG_ACCESS)       \
+               (((smmu)->options & ARM_SMMU_OPT_SECURE_CFG_ACCESS)     \
                        ? 0x400 : 0))
 
 /* Page table bits */