]> xenbits.xensource.com Git - people/gdunlap/xen.git/commitdiff
freemem: remove call to libxl_wait_for_free_memory
authorStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 6 Mar 2015 17:19:16 +0000 (17:19 +0000)
committerIan Campbell <ian.campbell@citrix.com>
Wed, 11 Mar 2015 11:36:38 +0000 (11:36 +0000)
Now that libxl_wait_for_memory_target is capable of waiting until dom0
reaches its target, we can remove the other wait function call:
libxl_wait_for_free_memory. No need to wait twice. Once dom0 has met its
target, simply loop again and recalculate free_memkb.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Reviewed-by: Mike Latimer <mlatimer@suse.com>
Tested-by: Mike Latimer <mlatimer@suse.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
tools/libxl/xl_cmdimpl.c

index 3c3bab3bcf90fc744f1c8a5cef83210049554ab7..399b6b6cee6acf19f8057add8ebc43cece0ab47b 100644 (file)
@@ -2220,15 +2220,9 @@ static int freemem(uint32_t domid, libxl_domain_build_info *b_info)
         if (rc < 0)
             return rc;
 
-        rc = libxl_wait_for_free_memory(ctx, domid, need_memkb, 10);
-        if (!rc)
-            return 0;
-        else if (rc != ERROR_NOMEM)
-            return rc;
-
         /* wait until dom0 reaches its target, as long as we are making
          * progress */
-        rc = libxl_wait_for_memory_target(ctx, 0, 1);
+        rc = libxl_wait_for_memory_target(ctx, 0, 10);
         if (rc < 0)
             return rc;