]> xenbits.xensource.com Git - people/royger/freebsd.git/commitdiff
cxgbe(4): dump_devlog should never fail silently.
authorNavdeep Parhar <np@FreeBSD.org>
Mon, 7 Mar 2022 19:17:05 +0000 (11:17 -0800)
committerNavdeep Parhar <np@FreeBSD.org>
Wed, 9 Mar 2022 22:45:11 +0000 (14:45 -0800)
Do the same thing as dump_cimla and log a warning on failure.

Sponsored by: Chelsio Communications

(cherry picked from commit 9282f04ff0ee89cc4064e510f7fa505cfc890bf0)

sys/dev/cxgbe/t4_main.c

index a9549abb48bb182003928409af249aa77ac8a4e5..2db23d218366c16a815213a076ce7466811366c8 100644 (file)
@@ -9500,8 +9500,11 @@ dump_devlog(struct adapter *sc)
        int rc;
        struct sbuf sb;
 
-       if (sbuf_new(&sb, NULL, 4096, SBUF_AUTOEXTEND) != &sb)
+       if (sbuf_new(&sb, NULL, 4096, SBUF_AUTOEXTEND) != &sb) {
+               log(LOG_DEBUG, "%s: failed to generate devlog dump.\n",
+                   device_get_nameunit(sc->dev));
                return;
+       }
        rc = sbuf_devlog(sc, &sb, M_NOWAIT);
        if (rc == 0) {
                rc = sbuf_finish(&sb);