]> xenbits.xensource.com Git - people/royger/xen.git/commitdiff
Revert "xen/x86: bzImage parse kernel_alignment"
authorJason Andryuk <jason.andryuk@amd.com>
Wed, 27 Mar 2024 08:13:34 +0000 (09:13 +0100)
committerJan Beulich <jbeulich@suse.com>
Wed, 27 Mar 2024 08:13:34 +0000 (09:13 +0100)
A new ELF note will specify the alignment for a relocatable PVH kernel.
ELF notes are suitable for vmlinux and other ELF files, so this
Linux-specific bzImage parsing in unnecessary.

This reverts commit c44cac229067faeec8f49247d1cf281723ac2d40.

Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/bzimage.c
xen/arch/x86/hvm/dom0_build.c
xen/arch/x86/include/asm/bzimage.h
xen/arch/x86/pv/dom0_build.c

index 0f4cfc49f7a587fa8a420a6d5324228c25a06618..ac4fd428be0ec618b45af72c3ab658034b822de4 100644 (file)
@@ -105,7 +105,7 @@ unsigned long __init bzimage_headroom(void *image_start,
 }
 
 int __init bzimage_parse(void *image_base, void **image_start,
-                         unsigned long *image_len, unsigned int *align)
+                         unsigned long *image_len)
 {
     struct setup_header *hdr = (struct setup_header *)(*image_start);
     int err = bzimage_check(hdr, *image_len);
@@ -118,8 +118,6 @@ int __init bzimage_parse(void *image_base, void **image_start,
     {
         *image_start += (hdr->setup_sects + 1) * 512 + hdr->payload_offset;
         *image_len = hdr->payload_length;
-        if ( align )
-            *align = hdr->kernel_alignment;
     }
 
     if ( elf_is_elfbinary(*image_start, *image_len) )
index bbae8a564522d5431195f7bb95f1c35bce1a2a6f..0ceda4140b297115ee375023102ba51552cd5068 100644 (file)
@@ -548,14 +548,12 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image,
     struct elf_binary elf;
     struct elf_dom_parms parms;
     paddr_t last_addr;
-    unsigned int align = 0;
     struct hvm_start_info start_info = { 0 };
     struct hvm_modlist_entry mod = { 0 };
     struct vcpu *v = d->vcpu[0];
     int rc;
 
-    rc = bzimage_parse(image_base, &image_start, &image_len, &align);
-    if ( rc != 0 )
+    if ( (rc = bzimage_parse(image_base, &image_start, &image_len)) != 0 )
     {
         printk("Error trying to detect bz compressed kernel\n");
         return rc;
index 2e04f5cc7ba5ad636981a10a6bde619436933063..7ed69d39103de7eba5bbf8fc79c83ffda1bd4d89 100644 (file)
@@ -6,6 +6,6 @@
 unsigned long bzimage_headroom(void *image_start, unsigned long image_length);
 
 int bzimage_parse(void *image_base, void **image_start,
-                  unsigned long *image_len, unsigned int *align);
+                  unsigned long *image_len);
 
 #endif /* __X86_BZIMAGE_H__ */
index e9fa8a9a826b406ef25a5b9e1158f770ddfd640a..d8043fa58a274f890fd57797a5c9aa3c589c55c4 100644 (file)
@@ -416,7 +416,7 @@ int __init dom0_construct_pv(struct domain *d,
 
     d->max_pages = ~0U;
 
-    if ( (rc = bzimage_parse(image_base, &image_start, &image_len, NULL)) != 0 )
+    if ( (rc = bzimage_parse(image_base, &image_start, &image_len)) != 0 )
         return rc;
 
     if ( (rc = elf_init(&elf, image_start, image_len)) != 0 )