]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Miscellaneous Block I/O tune cleanups
authorMartin Kletzander <mkletzan@redhat.com>
Thu, 26 Jan 2017 14:13:27 +0000 (15:13 +0100)
committerMartin Kletzander <mkletzan@redhat.com>
Sun, 29 Jan 2017 18:53:52 +0000 (19:53 +0100)
Well, just two.  One indentation and the usage of 'ret'.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
src/qemu/qemu_driver.c

index f45972e3c82300af3d66f4f0e84b411f2ad634b8..5a59037ee17e498ff81836b26afae43b7dbad77a 100644 (file)
@@ -17217,12 +17217,12 @@ qemuDomainSetBlockIoTuneDefaults(virDomainBlockIoTuneInfoPtr newinfo,
         newinfo->FIELD##_max_length = (newinfo->FIELD ||                       \
                                        newinfo->FIELD##_max) ? 1 : 0;
 
-        SET_MAX_LENGTH(BYTES_MAX_LENGTH, total_bytes_sec);
-        SET_MAX_LENGTH(BYTES_MAX_LENGTH, read_bytes_sec);
-        SET_MAX_LENGTH(BYTES_MAX_LENGTH, write_bytes_sec);
-        SET_MAX_LENGTH(IOPS_MAX_LENGTH, total_iops_sec);
-        SET_MAX_LENGTH(IOPS_MAX_LENGTH, read_iops_sec);
-        SET_MAX_LENGTH(IOPS_MAX_LENGTH, write_iops_sec);
+    SET_MAX_LENGTH(BYTES_MAX_LENGTH, total_bytes_sec);
+    SET_MAX_LENGTH(BYTES_MAX_LENGTH, read_bytes_sec);
+    SET_MAX_LENGTH(BYTES_MAX_LENGTH, write_bytes_sec);
+    SET_MAX_LENGTH(IOPS_MAX_LENGTH, total_iops_sec);
+    SET_MAX_LENGTH(IOPS_MAX_LENGTH, read_iops_sec);
+    SET_MAX_LENGTH(IOPS_MAX_LENGTH, write_iops_sec);
 
 #undef SET_MAX_LENGTH
 
@@ -17512,11 +17512,12 @@ qemuDomainSetBlockIoTune(virDomainPtr dom,
             ret = -1;
         if (ret < 0)
             goto endjob;
+        ret = -1;
         disk->blkdeviotune = info;
         info.group_name = NULL;
 
-        ret = virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps);
-        if (ret < 0)
+        if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir,
+                                vm, driver->caps) < 0)
             goto endjob;
 
         if (eventNparams) {
@@ -17537,12 +17538,13 @@ qemuDomainSetBlockIoTune(virDomainPtr dom,
                                          set_fields);
         conf_disk->blkdeviotune = info;
         info.group_name = NULL;
-        ret = virDomainSaveConfig(cfg->configDir, driver->caps, persistentDef);
-        if (ret < 0)
+        if (virDomainSaveConfig(cfg->configDir, driver->caps,
+                                persistentDef) < 0)
             goto endjob;
 
     }
 
+    ret = 0;
  endjob:
     qemuDomainObjEndJob(driver, vm);