]> xenbits.xensource.com Git - unikraft/libs/newlib.git/commitdiff
Suppress code style warnings when using GCC 6, 7 or 8
authorSimon Kuenzer <simon.kuenzer@neclab.eu>
Wed, 10 Apr 2019 09:27:39 +0000 (11:27 +0200)
committerFelipe Huici <felipe.huici@neclab.eu>
Fri, 12 Apr 2019 12:39:51 +0000 (14:39 +0200)
Supress code style warnings for external libnewlib sources when using
GCC 6, GCC 7, or GCC 8. The new warning suppression flags are
introduced depending on the GCC version that is in use.
Additionally, this patch name spaces `SUPPRESS_FLAGS` to
`LIBNEWLIB_SUPPRESS_FLAGS-y` and we remove the double definition of
`-Wno-implicit-function-declaration`.

Signed-off-by: Simon Kuenzer <simon.kuenzer@neclab.eu>
Reviewed-by: Felipe Huici <felipe.huici@neclab.eu>
Makefile.uk

index 5635f44a7d5e1e76e8148566e834d5c146ed47f5..82e4e6efa2f20f1d7ed398349988727e235317a7 100644 (file)
@@ -84,18 +84,22 @@ LIBNEWLIBM_CXXINCLUDES += -I$(LIBNEWLIB_LIBM)/common
 LIBNEWLIBC_CFLAGS-y       += -DMISSING_SYSCALL_NAMES -DMALLOC_PROVIDED
 
 # Suppress some warnings to make the build process look neater
-SUPPRESS_FLAGS += -Wno-unused-parameter -Wno-unused-variable -Wno-nonnull      \
+LIBNEWLIB_SUPPRESS_FLAGS-y += \
+-Wno-unused-parameter -Wno-unused-variable -Wno-nonnull                                \
 -Wno-unused-but-set-variable -Wno-unused-label -Wno-char-subscripts            \
 -Wno-unused-function -Wno-missing-field-initializers -Wno-uninitialized                \
 -Wno-array-bounds -Wno-maybe-uninitialized -Wno-pointer-sign -Wno-unused-value \
 -Wno-unused-macros -Wno-parentheses -Wno-implicit-function-declaration         \
 -Wno-missing-braces -Wno-endif-labels -Wno-unused-but-set-variable             \
--Wno-implicit-function-declaration -Wno-type-limits -Wno-sign-compare
+-Wno-type-limits -Wno-sign-compare
+LIBNEWLIB_SUPPRESS_FLAGS-$(call gcc_version_ge,6,0) += -Wno-misleading-indentation
+LIBNEWLIB_SUPPRESS_FLAGS-$(call gcc_version_ge,6,0) += -Wno-shift-negative-value
+LIBNEWLIB_SUPPRESS_FLAGS-$(call gcc_version_ge,7,0) += -Wno-implicit-fallthrough
 
-LIBNEWLIBC_CFLAGS-y   += $(SUPPRESS_FLAGS)
-LIBNEWLIBM_CFLAGS-y   += $(SUPPRESS_FLAGS)
-LIBNEWLIBC_CXXFLAGS-y += $(SUPPRESS_FLAGS)
-LIBNEWLIBM_CXXFLAGS-y += $(SUPPRESS_FLAGS)
+LIBNEWLIBC_CFLAGS-y   += $(LIBNEWLIB_SUPPRESS_FLAGS-y)
+LIBNEWLIBM_CFLAGS-y   += $(LIBNEWLIB_SUPPRESS_FLAGS-y)
+LIBNEWLIBC_CXXFLAGS-y += $(LIBNEWLIB_SUPPRESS_FLAGS-y)
+LIBNEWLIBM_CXXFLAGS-y += $(LIBNEWLIB_SUPPRESS_FLAGS-y)
 
 ################################################################################
 # OS dependencies code - Glue between Unicore and newlib