]> xenbits.xensource.com Git - qemu-upstream-4.6-testing.git/commitdiff
virtio-blk: remove need for explicit x-data-plane=on option
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 10 Jun 2014 07:03:22 +0000 (09:03 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 1 Jul 2014 07:15:02 +0000 (09:15 +0200)
The x-data-plane=on|off option is no longer useful because the
iothread=<iothread> option conveys the same information plus which
IOThread to use.

Do not delete x-data-plane=on|off yet as a convenience to people using
this legacy experimental option.  We will drop it in QEMU 2.2.

Instead, turn on data-plane when either x-data-plane=on or
iothread=<iothread> are used.  The following command-line uses
data-plane:

  qemu -device virtio-blk-pci,iothread=foo,drive=drive0

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/block/dataplane/virtio-blk.c

index f6e1a5d919fba98a8c8967bbcc41e69ef82864e4..4c5ba18122ed42bc5b9f7845fca2468ec553b78a 100644 (file)
@@ -132,7 +132,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk,
 
     *dataplane = NULL;
 
-    if (!blk->data_plane) {
+    if (!blk->data_plane && !blk->iothread) {
         return;
     }