]> xenbits.xensource.com Git - people/iwj/osstest.git/commitdiff
target_install_packages: Consistently use qw(...) rather than '...'
authorIan Jackson <ian.jackson@eu.citrix.com>
Fri, 5 Apr 2019 15:31:20 +0000 (16:31 +0100)
committerIan Jackson <ian.jackson@eu.citrix.com>
Wed, 10 Apr 2019 14:19:22 +0000 (15:19 +0100)
qw(...) splits its argument into words.

There is one semantic change, where two package names were passed in a
single argument.  That worked by accident.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
ts-xen-install

index 80952857a22304951ec831ef1e4d818867c63ad1..03f8c03e8a5688283dcc3d06f69a6996ea2978a8 100755 (executable)
@@ -53,18 +53,18 @@ sub packages () {
                               qemu-utils
                                netcat-openbsd));
     if ($ho->{Suite} !~ m/squeeze|wheezy|jessie/) {
-        target_install_packages($ho, 'net-tools libnl-route-3-200');
+        target_install_packages($ho, qw(net-tools libnl-route-3-200));
     }
     if ($ho->{Suite} =~ m/jessie/) {
-        target_install_packages($ho, 'libnl-route-3-200');
+        target_install_packages($ho, qw(libnl-route-3-200));
     }
     target_install_packages($ho,
                            $ho->{Suite} =~ /squeeze/ ? "libyajl1" : "libyajl2");
     if ($ho->{Suite} !~ m/lenny|squeeze/) {
-        target_install_packages($ho, 'libfdt1');
+        target_install_packages($ho, qw(libfdt1));
     }
     if ($r{arch} eq 'i386') {
-       target_install_packages($ho, 'libc6-xen');
+       target_install_packages($ho, qw(libc6-xen));
     }
     target_install_packages($ho, @{toolstack($ho)->{ExtraPackages}})
         if toolstack($ho)->{ExtraPackages};
@@ -88,7 +88,7 @@ sub some_extradebs ($) {
            $ontarget = "extrapackages-$cfgvar-$counter"; $counter++;
            $dpkgopts = '-iGROEB';
            logm("$cfgvar: updating packages from directory $path");
-           target_install_packages($ho, 'rsync') unless $rsync_installed++;
+           target_install_packages($ho, qw(rsync)) unless $rsync_installed++;
            target_putfile_root($ho,300, "$path/.", $ontarget, '-r');
        } elsif ($path =~ m{\.deb$}) {
            $path =~ s{_\.deb}{ "_$r{arch}.deb" }e;