]> xenbits.xensource.com Git - libvirt.git/commitdiff
libxlDomainMigrationDstPrepareDef: remove use of temporary variable
authorPeter Krempa <pkrempa@redhat.com>
Thu, 11 Jun 2020 08:16:34 +0000 (10:16 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 15 Jun 2020 08:27:37 +0000 (10:27 +0200)
We can free 'def->name' directly.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com
src/libxl/libxl_migration.c

index defdda5ed68e579d78d31105609f8510483b16b7..9d253346ebfd98f13453f108fe5a13b713684e82 100644 (file)
@@ -449,7 +449,6 @@ libxlDomainMigrationDstPrepareDef(libxlDriverPrivatePtr driver,
 {
     libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver);
     virDomainDefPtr def;
-    char *name = NULL;
 
     if (!dom_xml) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
@@ -464,13 +463,12 @@ libxlDomainMigrationDstPrepareDef(libxlDriverPrivatePtr driver,
         goto cleanup;
 
     if (dname) {
-        name = def->name;
+        VIR_FREE(def->name);
         def->name = g_strdup(dname);
     }
 
  cleanup:
     virObjectUnref(cfg);
-    VIR_FREE(name);
     return def;
 }