]> xenbits.xensource.com Git - people/aperard/xen-unstable.git/commitdiff
xen/x86: drop constanst_test_bit() in asm/bitops.h
authorOleksii Kurochko <oleksii.kurochko@gmail.com>
Wed, 31 Jul 2024 11:08:16 +0000 (13:08 +0200)
committerJan Beulich <jbeulich@suse.com>
Wed, 31 Jul 2024 11:08:16 +0000 (13:08 +0200)
constant_test_bit() is functionally the same as generic_test_bit(),
so constant_test_bit() can be dropped and replaced with
generic_test_bit().

Requested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/include/asm/bitops.h

index f9aa60111f5b6c5e668146af07d3b31f70212c6b..8c0403405aa2037363490b1a0b9288bea6c393dd 100644 (file)
@@ -277,12 +277,6 @@ static inline int test_and_change_bit(int nr, volatile void *addr)
     test_and_change_bit(nr, addr);                      \
 })
 
-static inline int constant_test_bit(int nr, const volatile void *addr)
-{
-    return ((1U << (nr & 31)) &
-            (((const volatile unsigned int *)addr)[nr >> 5])) != 0;
-}
-
 static inline int variable_test_bit(int nr, const volatile void *addr)
 {
     int oldbit;
@@ -297,7 +291,7 @@ static inline int variable_test_bit(int nr, const volatile void *addr)
 
 #define arch_test_bit(nr, addr) ({                      \
     __builtin_constant_p(nr) ?                          \
-        constant_test_bit(nr, addr) :                   \
+        generic_test_bit(nr, addr) :                    \
         variable_test_bit(nr, addr);                    \
 })