]> xenbits.xensource.com Git - xcp/xen-api-libs.git/commitdiff
camldm/camldm_stubs.c: Tests have confirmed that camldm_ls does not leak memory.
authorMatthias Goergens <Matthias.Goergens@citrix.com>
Thu, 17 Jun 2010 21:16:18 +0000 (22:16 +0100)
committerMatthias Goergens <Matthias.Goergens@citrix.com>
Thu, 17 Jun 2010 21:16:18 +0000 (22:16 +0100)
A comment in the file reflects this finding.

Signed-off-by: Matthias Goergens <matthias.goergens@citrix.com>
camldm/camldm_stubs.c

index ae05672131078e29be0aa0a7fe2f75a39e54ac04..929cea65f419c2ad83418af0cb5cc203e178565c 100644 (file)
@@ -238,9 +238,13 @@ void camldm_mknod(value path, value mode, value major, value minor)
   CAMLreturn0;
 }
 
-// may leak memory.  who knows?  (Does the c function I copied this
-// from (dmsetup.c) care about memory?  dmsetup exits shortly after executing
-// it.
+/*
+  May leak memory.  who knows?  (Does the c function (_process_all)
+  where I copied this from (dmsetup.c) care about memory?  dmsetup
+  exits shortly after executing it.  After testing: It does not seem
+  to leak.  Probably "dm_task_destroy(dmt);" is doing some cleaning
+  up.
+*/
 #define none Val_int(0)
 #define Tag_some Val_int(0)
 value camldm_ls()