qemuMonitorStartCPUs(qemuMonitorPtr mon,
virConnectPtr conn)
{
- int ret;
VIR_DEBUG("mon=%p", mon);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONStartCPUs(mon, conn);
+ return qemuMonitorJSONStartCPUs(mon, conn);
else
- ret = qemuMonitorTextStartCPUs(mon, conn);
- return ret;
+ return qemuMonitorTextStartCPUs(mon, conn);
}
int
qemuMonitorStopCPUs(qemuMonitorPtr mon)
{
- int ret;
VIR_DEBUG("mon=%p", mon);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONStopCPUs(mon);
+ return qemuMonitorJSONStopCPUs(mon);
else
- ret = qemuMonitorTextStopCPUs(mon);
- return ret;
+ return qemuMonitorTextStopCPUs(mon);
}
bool *running,
virDomainPausedReason *reason)
{
- int ret;
VIR_DEBUG("mon=%p, running=%p, reason=%p", mon, running, reason);
if (!mon || !running) {
}
if (mon->json)
- ret = qemuMonitorJSONGetStatus(mon, running, reason);
+ return qemuMonitorJSONGetStatus(mon, running, reason);
else
- ret = qemuMonitorTextGetStatus(mon, running, reason);
- return ret;
+ return qemuMonitorTextGetStatus(mon, running, reason);
}
int
qemuMonitorSystemPowerdown(qemuMonitorPtr mon)
{
- int ret;
VIR_DEBUG("mon=%p", mon);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONSystemPowerdown(mon);
+ return qemuMonitorJSONSystemPowerdown(mon);
else
- ret = qemuMonitorTextSystemPowerdown(mon);
- return ret;
+ return qemuMonitorTextSystemPowerdown(mon);
}
int
qemuMonitorSystemReset(qemuMonitorPtr mon)
{
- int ret;
VIR_DEBUG("mon=%p", mon);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONSystemReset(mon);
+ return qemuMonitorJSONSystemReset(mon);
else
- ret = qemuMonitorTextSystemReset(mon);
- return ret;
+ return qemuMonitorTextSystemReset(mon);
}
qemuMonitorGetCPUInfo(qemuMonitorPtr mon,
int **pids)
{
- int ret;
VIR_DEBUG("mon=%p", mon);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONGetCPUInfo(mon, pids);
+ return qemuMonitorJSONGetCPUInfo(mon, pids);
else
- ret = qemuMonitorTextGetCPUInfo(mon, pids);
- return ret;
+ return qemuMonitorTextGetCPUInfo(mon, pids);
}
const char *name,
virDomainNetInterfaceLinkState state)
{
- int ret;
VIR_DEBUG("mon=%p, name=%s, state=%u", mon, name, state);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONSetLink(mon, name, state);
+ return qemuMonitorJSONSetLink(mon, name, state);
else
- ret = qemuMonitorTextSetLink(mon, name, state);
- return ret;
+ return qemuMonitorTextSetLink(mon, name, state);
}
qemuMonitorGetVirtType(qemuMonitorPtr mon,
int *virtType)
{
- int ret;
VIR_DEBUG("mon=%p", mon);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONGetVirtType(mon, virtType);
+ return qemuMonitorJSONGetVirtType(mon, virtType);
else
- ret = qemuMonitorTextGetVirtType(mon, virtType);
- return ret;
+ return qemuMonitorTextGetVirtType(mon, virtType);
}
qemuMonitorGetBalloonInfo(qemuMonitorPtr mon,
unsigned long long *currmem)
{
- int ret;
VIR_DEBUG("mon=%p", mon);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONGetBalloonInfo(mon, currmem);
+ return qemuMonitorJSONGetBalloonInfo(mon, currmem);
else
- ret = qemuMonitorTextGetBalloonInfo(mon, currmem);
- return ret;
+ return qemuMonitorTextGetBalloonInfo(mon, currmem);
}
virDomainMemoryStatPtr stats,
unsigned int nr_stats)
{
- int ret;
VIR_DEBUG("mon=%p stats=%p nstats=%u", mon, stats, nr_stats);
if (!mon) {
if (mon->json) {
ignore_value(qemuMonitorFindBalloonObjectPath(mon, "/"));
mon->ballooninit = true;
- ret = qemuMonitorJSONGetMemoryStats(mon, mon->balloonpath,
- stats, nr_stats);
+ return qemuMonitorJSONGetMemoryStats(mon, mon->balloonpath,
+ stats, nr_stats);
} else {
- ret = qemuMonitorTextGetMemoryStats(mon, stats, nr_stats);
+ return qemuMonitorTextGetMemoryStats(mon, stats, nr_stats);
}
- return ret;
}
const char *dev_name,
unsigned long long *extent)
{
- int ret;
VIR_DEBUG("mon=%p, dev_name=%s", mon, dev_name);
if (mon->json)
- ret = qemuMonitorJSONGetBlockExtent(mon, dev_name, extent);
+ return qemuMonitorJSONGetBlockExtent(mon, dev_name, extent);
else
- ret = qemuMonitorTextGetBlockExtent(mon, dev_name, extent);
-
- return ret;
+ return qemuMonitorTextGetBlockExtent(mon, dev_name, extent);
}
const char *device,
unsigned long long size)
{
- int ret;
VIR_DEBUG("mon=%p, device=%s size=%llu", mon, device, size);
if (mon->json)
- ret = qemuMonitorJSONBlockResize(mon, device, size);
+ return qemuMonitorJSONBlockResize(mon, device, size);
else
- ret = qemuMonitorTextBlockResize(mon, device, size);
-
- return ret;
+ return qemuMonitorTextBlockResize(mon, device, size);
}
qemuMonitorSetVNCPassword(qemuMonitorPtr mon,
const char *password)
{
- int ret;
VIR_DEBUG("mon=%p, password=%p", mon, password);
if (!mon) {
password = "";
if (mon->json)
- ret = qemuMonitorJSONSetVNCPassword(mon, password);
+ return qemuMonitorJSONSetVNCPassword(mon, password);
else
- ret = qemuMonitorTextSetVNCPassword(mon, password);
- return ret;
+ return qemuMonitorTextSetVNCPassword(mon, password);
}
const char *action_if_connected)
{
const char *protocol = qemuMonitorTypeToProtocol(type);
- int ret;
if (!protocol)
return -1;
action_if_connected = "keep";
if (mon->json)
- ret = qemuMonitorJSONSetPassword(mon, protocol, password, action_if_connected);
+ return qemuMonitorJSONSetPassword(mon, protocol, password, action_if_connected);
else
- ret = qemuMonitorTextSetPassword(mon, protocol, password, action_if_connected);
- return ret;
+ return qemuMonitorTextSetPassword(mon, protocol, password, action_if_connected);
}
const char *expire_time)
{
const char *protocol = qemuMonitorTypeToProtocol(type);
- int ret;
if (!protocol)
return -1;
expire_time = "now";
if (mon->json)
- ret = qemuMonitorJSONExpirePassword(mon, protocol, expire_time);
+ return qemuMonitorJSONExpirePassword(mon, protocol, expire_time);
else
- ret = qemuMonitorTextExpirePassword(mon, protocol, expire_time);
- return ret;
+ return qemuMonitorTextExpirePassword(mon, protocol, expire_time);
}
qemuMonitorSetBalloon(qemuMonitorPtr mon,
unsigned long newmem)
{
- int ret;
VIR_DEBUG("mon=%p newmem=%lu", mon, newmem);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONSetBalloon(mon, newmem);
+ return qemuMonitorJSONSetBalloon(mon, newmem);
else
- ret = qemuMonitorTextSetBalloon(mon, newmem);
- return ret;
+ return qemuMonitorTextSetBalloon(mon, newmem);
}
int
qemuMonitorSetCPU(qemuMonitorPtr mon, int cpu, bool online)
{
- int ret;
VIR_DEBUG("mon=%p cpu=%d online=%d", mon, cpu, online);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONSetCPU(mon, cpu, online);
+ return qemuMonitorJSONSetCPU(mon, cpu, online);
else
- ret = qemuMonitorTextSetCPU(mon, cpu, online);
- return ret;
+ return qemuMonitorTextSetCPU(mon, cpu, online);
}
const char *dev_name,
bool force)
{
- int ret;
VIR_DEBUG("mon=%p dev_name=%s force=%d", mon, dev_name, force);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONEjectMedia(mon, dev_name, force);
+ return qemuMonitorJSONEjectMedia(mon, dev_name, force);
else
- ret = qemuMonitorTextEjectMedia(mon, dev_name, force);
- return ret;
+ return qemuMonitorTextEjectMedia(mon, dev_name, force);
}
const char *newmedia,
const char *format)
{
- int ret;
VIR_DEBUG("mon=%p dev_name=%s newmedia=%s format=%s",
mon, dev_name, newmedia, format);
}
if (mon->json)
- ret = qemuMonitorJSONChangeMedia(mon, dev_name, newmedia, format);
+ return qemuMonitorJSONChangeMedia(mon, dev_name, newmedia, format);
else
- ret = qemuMonitorTextChangeMedia(mon, dev_name, newmedia, format);
- return ret;
+ return qemuMonitorTextChangeMedia(mon, dev_name, newmedia, format);
}
size_t length,
const char *path)
{
- int ret;
VIR_DEBUG("mon=%p offset=%llu length=%zu path=%s",
mon, offset, length, path);
}
if (mon->json)
- ret = qemuMonitorJSONSaveVirtualMemory(mon, offset, length, path);
+ return qemuMonitorJSONSaveVirtualMemory(mon, offset, length, path);
else
- ret = qemuMonitorTextSaveVirtualMemory(mon, offset, length, path);
- return ret;
+ return qemuMonitorTextSaveVirtualMemory(mon, offset, length, path);
}
size_t length,
const char *path)
{
- int ret;
VIR_DEBUG("mon=%p offset=%llu length=%zu path=%s",
mon, offset, length, path);
}
if (mon->json)
- ret = qemuMonitorJSONSavePhysicalMemory(mon, offset, length, path);
+ return qemuMonitorJSONSavePhysicalMemory(mon, offset, length, path);
else
- ret = qemuMonitorTextSavePhysicalMemory(mon, offset, length, path);
- return ret;
+ return qemuMonitorTextSavePhysicalMemory(mon, offset, length, path);
}
qemuMonitorSetMigrationSpeed(qemuMonitorPtr mon,
unsigned long bandwidth)
{
- int ret;
VIR_DEBUG("mon=%p bandwidth=%lu", mon, bandwidth);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONSetMigrationSpeed(mon, bandwidth);
+ return qemuMonitorJSONSetMigrationSpeed(mon, bandwidth);
else
- ret = qemuMonitorTextSetMigrationSpeed(mon, bandwidth);
- return ret;
+ return qemuMonitorTextSetMigrationSpeed(mon, bandwidth);
}
qemuMonitorSetMigrationDowntime(qemuMonitorPtr mon,
unsigned long long downtime)
{
- int ret;
VIR_DEBUG("mon=%p downtime=%llu", mon, downtime);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONSetMigrationDowntime(mon, downtime);
+ return qemuMonitorJSONSetMigrationDowntime(mon, downtime);
else
- ret = qemuMonitorTextSetMigrationDowntime(mon, downtime);
- return ret;
+ return qemuMonitorTextSetMigrationDowntime(mon, downtime);
}
qemuMonitorGetMigrationStatus(qemuMonitorPtr mon,
qemuMonitorMigrationStatusPtr status)
{
- int ret;
VIR_DEBUG("mon=%p", mon);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONGetMigrationStatus(mon, status);
+ return qemuMonitorJSONGetMigrationStatus(mon, status);
else
- ret = qemuMonitorTextGetMigrationStatus(mon, status);
- return ret;
+ return qemuMonitorTextGetMigrationStatus(mon, status);
}
qemuMonitorGetSpiceMigrationStatus(qemuMonitorPtr mon,
bool *spice_migrated)
{
- int ret;
VIR_DEBUG("mon=%p", mon);
if (!mon) {
}
if (mon->json) {
- ret = qemuMonitorJSONGetSpiceMigrationStatus(mon, spice_migrated);
+ return qemuMonitorJSONGetSpiceMigrationStatus(mon, spice_migrated);
} else {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("JSON monitor is required"));
return -1;
}
-
- return ret;
}
int
qemuMonitorMigrateCancel(qemuMonitorPtr mon)
{
- int ret;
VIR_DEBUG("mon=%p", mon);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONMigrateCancel(mon);
+ return qemuMonitorJSONMigrateCancel(mon);
else
- ret = qemuMonitorTextMigrateCancel(mon);
- return ret;
+ return qemuMonitorTextMigrateCancel(mon);
}
int tlsPort,
const char *tlsSubject)
{
- int ret;
VIR_DEBUG("mon=%p type=%d hostname=%s port=%d tlsPort=%d tlsSubject=%s",
mon, type, hostname, port, tlsPort, NULLSTR(tlsSubject));
if (mon->json)
- ret = qemuMonitorJSONGraphicsRelocate(mon,
- type,
- hostname,
- port,
- tlsPort,
- tlsSubject);
+ return qemuMonitorJSONGraphicsRelocate(mon,
+ type,
+ hostname,
+ port,
+ tlsPort,
+ tlsSubject);
else
- ret = qemuMonitorTextGraphicsRelocate(mon,
- type,
- hostname,
- port,
- tlsPort,
- tlsSubject);
-
- return ret;
+ return qemuMonitorTextGraphicsRelocate(mon,
+ type,
+ hostname,
+ port,
+ tlsPort,
+ tlsSubject);
}
qemuMonitorAddUSBDisk(qemuMonitorPtr mon,
const char *path)
{
- int ret;
VIR_DEBUG("mon=%p path=%s", mon, path);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONAddUSBDisk(mon, path);
+ return qemuMonitorJSONAddUSBDisk(mon, path);
else
- ret = qemuMonitorTextAddUSBDisk(mon, path);
- return ret;
+ return qemuMonitorTextAddUSBDisk(mon, path);
}
int bus,
int dev)
{
- int ret;
VIR_DEBUG("mon=%p bus=%d dev=%d", mon, bus, dev);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONAddUSBDeviceExact(mon, bus, dev);
+ return qemuMonitorJSONAddUSBDeviceExact(mon, bus, dev);
else
- ret = qemuMonitorTextAddUSBDeviceExact(mon, bus, dev);
- return ret;
+ return qemuMonitorTextAddUSBDeviceExact(mon, bus, dev);
}
int vendor,
int product)
{
- int ret;
VIR_DEBUG("mon=%p vendor=%d product=%d", mon, vendor, product);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONAddUSBDeviceMatch(mon, vendor, product);
+ return qemuMonitorJSONAddUSBDeviceMatch(mon, vendor, product);
else
- ret = qemuMonitorTextAddUSBDeviceMatch(mon, vendor, product);
- return ret;
+ return qemuMonitorTextAddUSBDeviceMatch(mon, vendor, product);
}
virDevicePCIAddress *hostAddr,
virDevicePCIAddress *guestAddr)
{
- int ret;
VIR_DEBUG("mon=%p domain=%d bus=%d slot=%d function=%d",
mon, hostAddr->domain, hostAddr->bus, hostAddr->slot,
hostAddr->function);
}
if (mon->json)
- ret = qemuMonitorJSONAddPCIHostDevice(mon, hostAddr, guestAddr);
+ return qemuMonitorJSONAddPCIHostDevice(mon, hostAddr, guestAddr);
else
- ret = qemuMonitorTextAddPCIHostDevice(mon, hostAddr, guestAddr);
- return ret;
+ return qemuMonitorTextAddPCIHostDevice(mon, hostAddr, guestAddr);
}
const char *bus,
virDevicePCIAddress *guestAddr)
{
- int ret;
VIR_DEBUG("mon=%p path=%s bus=%s", mon, path, bus);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONAddPCIDisk(mon, path, bus, guestAddr);
+ return qemuMonitorJSONAddPCIDisk(mon, path, bus, guestAddr);
else
- ret = qemuMonitorTextAddPCIDisk(mon, path, bus, guestAddr);
- return ret;
+ return qemuMonitorTextAddPCIDisk(mon, path, bus, guestAddr);
}
const char *nicstr,
virDevicePCIAddress *guestAddr)
{
- int ret;
VIR_DEBUG("mon=%p nicstr=%s", mon, nicstr);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONAddPCINetwork(mon, nicstr, guestAddr);
+ return qemuMonitorJSONAddPCINetwork(mon, nicstr, guestAddr);
else
- ret = qemuMonitorTextAddPCINetwork(mon, nicstr, guestAddr);
- return ret;
+ return qemuMonitorTextAddPCINetwork(mon, nicstr, guestAddr);
}
qemuMonitorRemovePCIDevice(qemuMonitorPtr mon,
virDevicePCIAddress *guestAddr)
{
- int ret;
VIR_DEBUG("mon=%p domain=%d bus=%d slot=%d function=%d",
mon, guestAddr->domain, guestAddr->bus,
guestAddr->slot, guestAddr->function);
}
if (mon->json)
- ret = qemuMonitorJSONRemovePCIDevice(mon, guestAddr);
+ return qemuMonitorJSONRemovePCIDevice(mon, guestAddr);
else
- ret = qemuMonitorTextRemovePCIDevice(mon, guestAddr);
- return ret;
+ return qemuMonitorTextRemovePCIDevice(mon, guestAddr);
}
const char *fdname,
int fd)
{
- int ret;
VIR_DEBUG("mon=%p, fdname=%s fd=%d", mon, fdname, fd);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONSendFileHandle(mon, fdname, fd);
+ return qemuMonitorJSONSendFileHandle(mon, fdname, fd);
else
- ret = qemuMonitorTextSendFileHandle(mon, fdname, fd);
- return ret;
+ return qemuMonitorTextSendFileHandle(mon, fdname, fd);
}
int
qemuMonitorAddFd(qemuMonitorPtr mon, int fdset, int fd, const char *name)
{
- int ret = -1;
VIR_DEBUG("mon=%p, fdset=%d, fd=%d, name=%s", mon, fdset, fd, NULLSTR(name));
if (!mon) {
return -1;
}
- if (mon->json)
- ret = qemuMonitorJSONAddFd(mon, fdset, fd, name);
- else
+ if (mon->json) {
+ return qemuMonitorJSONAddFd(mon, fdset, fd, name);
+ } else {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("add fd requires JSON monitor"));
- return ret;
+ return -1;
+ }
}
int vlan,
const char *netname)
{
- int ret = -1;
VIR_DEBUG("mon=%p netname=%s", mon, netname);
if (!mon) {
return -1;
}
- if (mon->json)
+ if (mon->json) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("JSON monitor should be using RemoveNetdev"));
- else
- ret = qemuMonitorTextRemoveHostNetwork(mon, vlan, netname);
- return ret;
+ return -1;
+ }
+
+ return qemuMonitorTextRemoveHostNetwork(mon, vlan, netname);
}
qemuMonitorRemoveNetdev(qemuMonitorPtr mon,
const char *alias)
{
- int ret;
VIR_DEBUG("mon=%p alias=%s", mon, alias);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONRemoveNetdev(mon, alias);
+ return qemuMonitorJSONRemoveNetdev(mon, alias);
else
- ret = qemuMonitorTextRemoveNetdev(mon, alias);
- return ret;
+ return qemuMonitorTextRemoveNetdev(mon, alias);
}
qemuMonitorQueryRxFilter(qemuMonitorPtr mon, const char *alias,
virNetDevRxFilterPtr *filter)
{
- int ret = -1;
VIR_DEBUG("mon=%p alias=%s filter=%p", mon, alias, filter);
if (!mon) {
return -1;
}
- if (mon->json)
- ret = qemuMonitorJSONQueryRxFilter(mon, alias, filter);
- else
+ if (!mon->json) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("query-rx-filter requires JSON monitor"));
- return ret;
+ return -1;
+ }
+
+ return qemuMonitorJSONQueryRxFilter(mon, alias, filter);
}
virDevicePCIAddress *guestAddr)
{
VIR_DEBUG("mon=%p type=%s", mon, bus);
- int ret;
if (!mon) {
virReportError(VIR_ERR_INVALID_ARG, "%s",
}
if (mon->json)
- ret = qemuMonitorJSONAttachPCIDiskController(mon, bus, guestAddr);
+ return qemuMonitorJSONAttachPCIDiskController(mon, bus, guestAddr);
else
- ret = qemuMonitorTextAttachPCIDiskController(mon, bus, guestAddr);
-
- return ret;
+ return qemuMonitorTextAttachPCIDiskController(mon, bus, guestAddr);
}
VIR_DEBUG("mon=%p drivestr=%s domain=%d bus=%d slot=%d function=%d",
mon, drivestr, controllerAddr->domain, controllerAddr->bus,
controllerAddr->slot, controllerAddr->function);
- int ret = 1;
if (!mon) {
virReportError(VIR_ERR_INVALID_ARG, "%s",
return -1;
}
- if (mon->json)
+ if (mon->json) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("JSON monitor should be using AddDrive"));
- else
- ret = qemuMonitorTextAttachDrive(mon, drivestr, controllerAddr, driveAddr);
+ return -1;
+ }
- return ret;
+ return qemuMonitorTextAttachDrive(mon, drivestr, controllerAddr, driveAddr);
}
qemuMonitorPCIAddress **addrs)
{
VIR_DEBUG("mon=%p addrs=%p", mon, addrs);
- int ret;
if (!mon) {
virReportError(VIR_ERR_INVALID_ARG, "%s",
}
if (mon->json)
- ret = qemuMonitorJSONGetAllPCIAddresses(mon, addrs);
+ return qemuMonitorJSONGetAllPCIAddresses(mon, addrs);
else
- ret = qemuMonitorTextGetAllPCIAddresses(mon, addrs);
- return ret;
+ return qemuMonitorTextGetAllPCIAddresses(mon, addrs);
}
const char *drivestr)
{
VIR_DEBUG("mon=%p drivestr=%s", mon, drivestr);
- int ret;
if (!mon) {
virReportError(VIR_ERR_INVALID_ARG, "%s",
}
if (mon->json)
- ret = qemuMonitorJSONDriveDel(mon, drivestr);
+ return qemuMonitorJSONDriveDel(mon, drivestr);
else
- ret = qemuMonitorTextDriveDel(mon, drivestr);
- return ret;
+ return qemuMonitorTextDriveDel(mon, drivestr);
}
const char *devalias)
{
VIR_DEBUG("mon=%p devalias=%s", mon, devalias);
- int ret;
if (!mon) {
virReportError(VIR_ERR_INVALID_ARG, "%s",
}
if (mon->json)
- ret = qemuMonitorJSONDelDevice(mon, devalias);
+ return qemuMonitorJSONDelDevice(mon, devalias);
else
- ret = qemuMonitorTextDelDevice(mon, devalias);
- return ret;
+ return qemuMonitorTextDelDevice(mon, devalias);
}
{
VIR_DEBUG("mon=%p type=%s objalias=%s props=%p",
mon, type, objalias, props);
- int ret = -1;
- if (mon->json) {
- ret = qemuMonitorJSONAddObject(mon, type, objalias, props);
- } else {
+ if (!mon->json) {
virJSONValueFree(props);
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("object adding requires JSON monitor"));
+ return -1;
}
- return ret;
+ return qemuMonitorJSONAddObject(mon, type, objalias, props);
}
const char *objalias)
{
VIR_DEBUG("mon=%p objalias=%s", mon, objalias);
- int ret = -1;
- if (mon->json)
- ret = qemuMonitorJSONDelObject(mon, objalias);
- else
+ if (!mon->json) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("object deletion requires JSON monitor"));
+ return -1;
+ }
- return ret;
+ return qemuMonitorJSONDelObject(mon, objalias);
}
const char *drivestr)
{
VIR_DEBUG("mon=%p drive=%s", mon, drivestr);
- int ret;
if (!mon) {
virReportError(VIR_ERR_INVALID_ARG, "%s",
}
if (mon->json)
- ret = qemuMonitorJSONAddDrive(mon, drivestr);
+ return qemuMonitorJSONAddDrive(mon, drivestr);
else
- ret = qemuMonitorTextAddDrive(mon, drivestr);
- return ret;
+ return qemuMonitorTextAddDrive(mon, drivestr);
}
const char *passphrase)
{
VIR_DEBUG("mon=%p alias=%s passphrase=%p(value hidden)", mon, alias, passphrase);
- int ret;
if (!mon) {
virReportError(VIR_ERR_INVALID_ARG, "%s",
}
if (mon->json)
- ret = qemuMonitorJSONSetDrivePassphrase(mon, alias, passphrase);
+ return qemuMonitorJSONSetDrivePassphrase(mon, alias, passphrase);
else
- ret = qemuMonitorTextSetDrivePassphrase(mon, alias, passphrase);
- return ret;
+ return qemuMonitorTextSetDrivePassphrase(mon, alias, passphrase);
}
int
qemuMonitorCreateSnapshot(qemuMonitorPtr mon, const char *name)
{
- int ret;
-
VIR_DEBUG("mon=%p, name=%s", mon, name);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONCreateSnapshot(mon, name);
+ return qemuMonitorJSONCreateSnapshot(mon, name);
else
- ret = qemuMonitorTextCreateSnapshot(mon, name);
- return ret;
+ return qemuMonitorTextCreateSnapshot(mon, name);
}
int
qemuMonitorLoadSnapshot(qemuMonitorPtr mon, const char *name)
{
- int ret;
-
VIR_DEBUG("mon=%p, name=%s", mon, name);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONLoadSnapshot(mon, name);
+ return qemuMonitorJSONLoadSnapshot(mon, name);
else
- ret = qemuMonitorTextLoadSnapshot(mon, name);
- return ret;
+ return qemuMonitorTextLoadSnapshot(mon, name);
}
int
qemuMonitorDeleteSnapshot(qemuMonitorPtr mon, const char *name)
{
- int ret;
-
VIR_DEBUG("mon=%p, name=%s", mon, name);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONDeleteSnapshot(mon, name);
+ return qemuMonitorJSONDeleteSnapshot(mon, name);
else
- ret = qemuMonitorTextDeleteSnapshot(mon, name);
- return ret;
+ return qemuMonitorTextDeleteSnapshot(mon, name);
}
const char *device, const char *file,
const char *format, bool reuse)
{
- int ret = -1;
-
VIR_DEBUG("mon=%p, actions=%p, device=%s, file=%s, format=%s, reuse=%d",
mon, actions, device, file, format, reuse);
return -1;
}
- if (mon->json)
- ret = qemuMonitorJSONDiskSnapshot(mon, actions, device, file, format,
- reuse);
- else
+ if (!mon->json) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("disk snapshot requires JSON monitor"));
- return ret;
+ }
+
+ return qemuMonitorJSONDiskSnapshot(mon, actions, device, file, format, reuse);
}
unsigned int granularity, unsigned long long buf_size,
unsigned int flags)
{
- int ret = -1;
-
VIR_DEBUG("mon=%p, device=%s, file=%s, format=%s, bandwidth=%lld, "
"granularity=%#x, buf_size=%lld, flags=%x",
mon, device, file, NULLSTR(format), bandwidth, granularity,
buf_size, flags);
- if (mon->json)
- ret = qemuMonitorJSONDriveMirror(mon, device, file, format, bandwidth,
- granularity, buf_size, flags);
- else
+ if (!mon->json) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("drive-mirror requires JSON monitor"));
- return ret;
+ return -1;
+ }
+
+ return qemuMonitorJSONDriveMirror(mon, device, file, format, bandwidth,
+ granularity, buf_size, flags);
}
int
qemuMonitorTransaction(qemuMonitorPtr mon, virJSONValuePtr actions)
{
- int ret = -1;
-
VIR_DEBUG("mon=%p, actions=%p", mon, actions);
- if (mon->json)
- ret = qemuMonitorJSONTransaction(mon, actions);
- else
+ if (!mon->json) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("transaction requires JSON monitor"));
- return ret;
+ }
+
+ return qemuMonitorJSONTransaction(mon, actions);
}
const char *backingName,
unsigned long long bandwidth)
{
- int ret = -1;
-
VIR_DEBUG("mon=%p, device=%s, top=%s, base=%s, backingName=%s, "
"bandwidth=%llu",
mon, device, top, base, NULLSTR(backingName), bandwidth);
- if (mon->json)
- ret = qemuMonitorJSONBlockCommit(mon, device, top, base,
- backingName, bandwidth);
- else
+ if (!mon->json) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("block-commit requires JSON monitor"));
- return ret;
+ return -1;
+ }
+
+ return qemuMonitorJSONBlockCommit(mon, device, top, base,
+ backingName, bandwidth);
}
char **reply,
bool hmp)
{
- int ret;
-
VIR_DEBUG("mon=%p, cmd=%s, reply=%p, hmp=%d", mon, cmd, reply, hmp);
if (mon->json)
- ret = qemuMonitorJSONArbitraryCommand(mon, cmd, reply, hmp);
+ return qemuMonitorJSONArbitraryCommand(mon, cmd, reply, hmp);
else
- ret = qemuMonitorTextArbitraryCommand(mon, cmd, reply);
- return ret;
+ return qemuMonitorTextArbitraryCommand(mon, cmd, reply);
}
int
qemuMonitorInjectNMI(qemuMonitorPtr mon)
{
- int ret;
-
VIR_DEBUG("mon=%p", mon);
if (mon->json)
- ret = qemuMonitorJSONInjectNMI(mon);
+ return qemuMonitorJSONInjectNMI(mon);
else
- ret = qemuMonitorTextInjectNMI(mon);
- return ret;
+ return qemuMonitorTextInjectNMI(mon);
}
unsigned int *keycodes,
unsigned int nkeycodes)
{
- int ret;
-
VIR_DEBUG("mon=%p, holdtime=%u, nkeycodes=%u", mon, holdtime, nkeycodes);
if (mon->json)
- ret = qemuMonitorJSONSendKey(mon, holdtime, keycodes, nkeycodes);
+ return qemuMonitorJSONSendKey(mon, holdtime, keycodes, nkeycodes);
else
- ret = qemuMonitorTextSendKey(mon, holdtime, keycodes, nkeycodes);
- return ret;
+ return qemuMonitorTextSendKey(mon, holdtime, keycodes, nkeycodes);
}
qemuMonitorScreendump(qemuMonitorPtr mon,
const char *file)
{
-
- int ret;
-
VIR_DEBUG("mon=%p, file=%s", mon, file);
if (!mon) {
}
if (mon->json)
- ret = qemuMonitorJSONScreendump(mon, file);
+ return qemuMonitorJSONScreendump(mon, file);
else
- ret = qemuMonitorTextScreendump(mon, file);
- return ret;
+ return qemuMonitorTextScreendump(mon, file);
}
virDomainBlockJobInfoPtr info,
unsigned long long *bandwidth)
{
- int ret = -1;
-
VIR_DEBUG("mon=%p, device=%s, info=%p, bandwidth=%p",
mon, device, info, bandwidth);
- if (mon->json)
- ret = qemuMonitorJSONBlockJobInfo(mon, device, info, bandwidth);
- else
+ if (!mon->json) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("block jobs require JSON monitor"));
- return ret;
+ return -1;
+ }
+
+ return qemuMonitorJSONBlockJobInfo(mon, device, info, bandwidth);
}
virDomainBlockIoTuneInfoPtr info,
bool supportMaxOptions)
{
- int ret;
-
VIR_DEBUG("mon=%p, device=%p, info=%p", mon, device, info);
- if (mon->json) {
- ret = qemuMonitorJSONSetBlockIoThrottle(mon, device, info, supportMaxOptions);
- } else {
- ret = qemuMonitorTextSetBlockIoThrottle(mon, device, info);
- }
- return ret;
+ if (mon->json)
+ return qemuMonitorJSONSetBlockIoThrottle(mon, device, info, supportMaxOptions);
+ else
+ return qemuMonitorTextSetBlockIoThrottle(mon, device, info);
}
virDomainBlockIoTuneInfoPtr reply,
bool supportMaxOptions)
{
- int ret;
-
VIR_DEBUG("mon=%p, device=%p, reply=%p", mon, device, reply);
- if (mon->json) {
- ret = qemuMonitorJSONGetBlockIoThrottle(mon, device, reply, supportMaxOptions);
- } else {
- ret = qemuMonitorTextGetBlockIoThrottle(mon, device, reply);
- }
- return ret;
+ if (mon->json)
+ return qemuMonitorJSONGetBlockIoThrottle(mon, device, reply, supportMaxOptions);
+ else
+ return qemuMonitorTextGetBlockIoThrottle(mon, device, reply);
}