]> xenbits.xensource.com Git - libvirt.git/commitdiff
libxl: remove 'ret' from xenParseSxprVifRate
authorJán Tomko <jtomko@redhat.com>
Wed, 13 Nov 2019 12:09:11 +0000 (13:09 +0100)
committerJán Tomko <jtomko@redhat.com>
Thu, 14 Nov 2019 16:45:40 +0000 (17:45 +0100)
Now that the cleanup section is empty, the ret variable is no longer
necessary.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/libxl/xen_common.c

index 7dd06b67c360581f20d78efae172304dff623ae7..b6c96799d965beb74984ea32c3c91f80c47a3208 100644 (file)
@@ -1067,7 +1067,6 @@ xenParseSxprVifRate(const char *rate, unsigned long long *kbytes_per_sec)
     char *p;
     char *suffix;
     unsigned long long tmp;
-    int ret = -1;
 
     trate = g_strdup(rate);
 
@@ -1085,13 +1084,13 @@ xenParseSxprVifRate(const char *rate, unsigned long long *kbytes_per_sec)
     if (!g_regex_match(regex, trate, 0, NULL)) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("Invalid rate '%s' specified"), rate);
-        goto cleanup;
+        return -1;
     }
 
     if (virStrToLong_ull(rate, &suffix, 10, &tmp)) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("Failed to parse rate '%s'"), rate);
-        goto cleanup;
+        return -1;
     }
 
     if (*suffix == 'G')
@@ -1103,10 +1102,7 @@ xenParseSxprVifRate(const char *rate, unsigned long long *kbytes_per_sec)
        tmp /= 8;
 
     *kbytes_per_sec = tmp;
-    ret = 0;
-
- cleanup:
-    return ret;
+    return 0;
 }