macvtap: avoid invalid free

Commit 0472f39 plugged a leak, but introduced another bug:

Actually looks like physfndev is conditionally allocated in getPhysfnDev
Its better to modify getPhysfnDev to allocate physfndev every time.

diff --git a/src/util/macvtap.c b/src/util/macvtap.c
index a020c9058bb50495d1dfa26a7fc53f3dcab7ce12..7fd6eb54b9952c02c1c2b7f5e59951fd6ae98435 100644 (file)
--- a/src/util/macvtap.c
+++ b/src/util/macvtap.c
@@ -964,7 +964,11 @@ getPhysfnDev(const char *linkdev,
          */
 
         *vf = PORT_SELF_VF;
-        *physfndev = (char *)linkdev;
+        *physfndev = strdup(linkdev);
+        if (!*physfndev) {
+            virReportOOMError();
+            rc = -1;
+        }
     }
 
     return rc;