]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: validate: Remove impossible validation checks
authorPeter Krempa <pkrempa@redhat.com>
Tue, 19 Jul 2022 19:10:33 +0000 (21:10 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 11 Aug 2022 13:08:16 +0000 (15:08 +0200)
All supported qemu versions now work with blockdev.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_validate.c

index b13c27bcf09c241ba091c0409e367da51260e872..5c68a65fdcc30cdf3ce439065ea18b3641090f50 100644 (file)
@@ -707,13 +707,6 @@ qemuValidateDomainDefNvram(const virDomainDef *def,
     if (!src)
         return 0;
 
-    if (def->os.loader->newStyleNVRAM &&
-        !virQEMUCapsGet(qemuCaps, QEMU_CAPS_BLOCKDEV)) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                       _("modern nvram specification is not supported by this qemu"));
-        return -1;
-    }
-
     switch (src->type) {
     case VIR_STORAGE_TYPE_FILE:
     case VIR_STORAGE_TYPE_BLOCK:
@@ -3315,13 +3308,6 @@ qemuValidateDomainDeviceDefDiskTransient(const virDomainDiskDef *disk,
         return -1;
     }
 
-    if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_BLOCKDEV)) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                       _("transient disk not supported by this QEMU binary (%s)"),
-                       disk->dst);
-        return -1;
-    }
-
     if (disk->transientShareBacking == VIR_TRISTATE_BOOL_YES) {
         if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_SET_ACTION) &&
             !qemuProcessRebootAllowed(def)) {