]> xenbits.xensource.com Git - legacy/linux-2.6.18-xen.git/commitdiff
blktap2: Fwd: Fix wild ptr deref during device destruction.
authorKeir Fraser <keir.fraser@citrix.com>
Mon, 1 Mar 2010 09:55:54 +0000 (09:55 +0000)
committerKeir Fraser <keir.fraser@citrix.com>
Mon, 1 Mar 2010 09:55:54 +0000 (09:55 +0000)
A put_disk() before blk_cleanup_queue() would free gd before gd->queue
is read.

Signed-off-by: Daniel Stodden <daniel.stodden@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@novell.com>
drivers/xen/blktap2/device.c

index db5b3cb9567c1e894cfbc93a40743fa7a18d626f..eb21e9683fc2c776f57c889fa8ef1820e92b2622 100644 (file)
@@ -1082,8 +1082,8 @@ blktap_device_destroy(struct blktap *tap)
 #endif
 
        del_gendisk(dev->gd);
-       put_disk(dev->gd);
        blk_cleanup_queue(dev->gd->queue);
+       put_disk(dev->gd);
 
        dev->gd = NULL;