]> xenbits.xensource.com Git - people/aperard/linux.git/commitdiff
drm/radeon/ni: Fix wrong firmware size logging in ni_init_microcode()
authorNikita Zhandarovich <n.zhandarovich@fintech.ru>
Tue, 6 Feb 2024 16:48:14 +0000 (08:48 -0800)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:20:47 +0000 (18:20 -0400)
[ Upstream commit c4891d979c7668b195a0a75787967ec95a24ecef ]

Clean up a typo in pr_err() erroneously printing NI MC 'rdev->mc_fw->size'
during SMC firmware load. Log 'rdev->smc_fw->size' instead.

Found by Linux Verification Center (linuxtesting.org) with static
analysis tool SVACE.

Fixes: 6596afd48af4 ("drm/radeon/kms: add dpm support for btc (v3)")
Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/radeon/ni.c

index 927e5f42e97d018240b5204c9d0dd7339391292a..3e48cbb522a1ca6008ed52dce4df7ff248f8a777 100644 (file)
@@ -813,7 +813,7 @@ int ni_init_microcode(struct radeon_device *rdev)
                        err = 0;
                } else if (rdev->smc_fw->size != smc_req_size) {
                        pr_err("ni_mc: Bogus length %zu in firmware \"%s\"\n",
-                              rdev->mc_fw->size, fw_name);
+                              rdev->smc_fw->size, fw_name);
                        err = -EINVAL;
                }
        }