Enable -Wmissing-format-attribute warning

Add a couple of missing ATTRIBUTE_FMT_PRINTF annotations

* tools/virsh.c, tests/testutils.c: Add printf format attribute
* m4/virt-compile-warnings.m4: Enable -Wmissing-format-attribute

diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4
index 9dbc90e0eee25349fc8c3167f9214ab5a2d2b0d8..0431074cb6ed626727c9f76ce35d3f3e9b03a47e 100644 (file)
--- a/m4/virt-compile-warnings.m4
+++ b/m4/virt-compile-warnings.m4
@@ -67,7 +67,6 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
         dontwarn="$dontwarn -Wpacked"
         dontwarn="$dontwarn -Wunused-macros"
         dontwarn="$dontwarn -Woverlength-strings"
-        dontwarn="$dontwarn -Wmissing-format-attribute"
         dontwarn="$dontwarn -Wstack-protector"
 
         # Get all possible GCC warnings

diff --git a/tests/testutils.c b/tests/testutils.c
index 3110457cb24720b83d646d935bd16a3bb1ef17dc..0ce3c7bf56b812a99cce165e2cdec5d91c1b6d24 100644 (file)
--- a/tests/testutils.c
+++ b/tests/testutils.c
@@ -67,7 +67,7 @@ virtTestCountAverage(double *items, int nitems)
     return (double) (sum / nitems);
 }
 
-
+ATTRIBUTE_FMT_PRINTF(3,4)
 void virtTestResult(const char *name, int ret, const char *msg, ...)
 {
     va_list vargs;

diff --git a/tools/virsh.c b/tools/virsh.c
index 99da054bff263a62558507c165162a35c8e3c45b..f2d2c9d1a5ad03d282d43eba903cd2e4025f72a9 100644 (file)
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -243,7 +243,8 @@ static int vshInit(vshControl *ctl);
 static int vshDeinit(vshControl *ctl);
 static void vshUsage(void);
 static void vshOpenLogFile(vshControl *ctl);
-static void vshOutputLogFile(vshControl *ctl, int log_level, const char *format, va_list ap);
+static void vshOutputLogFile(vshControl *ctl, int log_level, const char *format, va_list ap)
+    ATTRIBUTE_FMT_PRINTF(3, 0);
 static void vshCloseLogFile(vshControl *ctl);
 
 static int vshParseArgv(vshControl *ctl, int argc, char **argv);