]> xenbits.xensource.com Git - libvirt.git/commitdiff
virnetdaemon.c: Use struct zero initializer instead of memset
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 3 Aug 2023 07:45:14 +0000 (09:45 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 3 Aug 2023 14:41:19 +0000 (16:41 +0200)
Ideally, these would be fixed by coccinelle (see next commit),
but because of various reasons they aren't. Fix them manually.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
src/rpc/virnetdaemon.c

index 554b8852e4b4067d50b84cffea0c025f3a46489a..d37984d207faa6abb33d18dc16af992bc826047a 100644 (file)
@@ -134,7 +134,7 @@ virNetDaemonNew(void)
 {
     virNetDaemon *dmn;
 #ifndef WIN32
-    struct sigaction sig_action;
+    struct sigaction sig_action = { 0 };
 #endif /* !WIN32 */
 
     if (virNetDaemonInitialize() < 0)
@@ -160,7 +160,6 @@ virNetDaemonNew(void)
     dmn->autoShutdownTimerID = -1;
 
 #ifndef WIN32
-    memset(&sig_action, 0, sizeof(sig_action));
     sig_action.sa_handler = SIG_IGN;
     sigaction(SIGPIPE, &sig_action, NULL);
 #endif /* !WIN32 */
@@ -599,12 +598,10 @@ virNetDaemonSignalHandler(int sig, siginfo_t * siginfo,
 {
     int origerrno;
     int r;
-    siginfo_t tmp;
+    siginfo_t tmp = { 0 };
 
     if (SA_SIGINFO)
         tmp = *siginfo;
-    else
-        memset(&tmp, 0, sizeof(tmp));
 
     /* set the sig num in the struct */
     tmp.si_signo = sig;