]> xenbits.xensource.com Git - seabios.git/commitdiff
USB-EHCI: Fix null pointer assignment
authorAvik Sil <aviksil@linux.vnet.ibm.com>
Thu, 14 Feb 2013 05:24:57 +0000 (10:54 +0530)
committerKevin O'Connor <kevin@koconnor.net>
Thu, 14 Feb 2013 13:32:02 +0000 (08:32 -0500)
cntl->regs should not be accessed before initializing it.

Signed-off-by: Avik Sil <aviksil@linux.vnet.ibm.com>
src/usb-ehci.c

index f28f343ed1c4a0a4968bda1134ecad9ae5367b16..69a9194e20ca0927bb75d4fdba2b4f3c1e52f7fc 100644 (file)
@@ -347,9 +347,9 @@ ehci_setup(struct pci_device *pci, int busid, struct pci_device *comppci)
     cntl->usb.pci = pci;
     cntl->usb.type = USB_TYPE_EHCI;
     cntl->caps = caps;
+    cntl->regs = (void*)caps + readb(&caps->caplength);
     if (hcc_params & HCC_64BIT_ADDR)
         cntl->regs->ctrldssegment = 0;
-    cntl->regs = (void*)caps + readb(&caps->caplength);
 
     dprintf(1, "EHCI init on dev %02x:%02x.%x (regs=%p)\n"
             , pci_bdf_to_bus(bdf), pci_bdf_to_dev(bdf)