]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemuMonitorTestNew: Call qemuMonitorOpen with 'retry' false
authorPeter Krempa <pkrempa@redhat.com>
Tue, 2 Aug 2022 11:54:35 +0000 (13:54 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 3 Aug 2022 12:26:56 +0000 (14:26 +0200)
The 'retry' argument makes the monitor connection opening re-try the
connection in case the monitor socket doesn't exist or isn't properly
listening. In case of the test code this can't happen because the socket
is created and made listening in 'qemuMonitorCommonTestNew' which is
called prior to calling 'qemuMonitorOpen'.

We can thus avoit the code which attempts retries in monitor connection.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
tests/qemumonitortestutils.c

index 50808f1fb5c5100cb4420470649f001cec70e779..1ea8d7271114eb0ede577432b99a4d5caa0e5f40 100644 (file)
@@ -1109,7 +1109,7 @@ qemuMonitorTestNew(virDomainXMLOption *xmlopt,
     test->qapischema = schema;
     if (!(test->mon = qemuMonitorOpen(test->vm,
                                       &src,
-                                      true,
+                                      false,
                                       virEventThreadGetContext(test->eventThread),
                                       &qemuMonitorTestCallbacks)))
         goto error;