]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
scripts/checkpatch: Improve the check for authors mangled by the mailing list
authorThomas Huth <thuth@redhat.com>
Tue, 16 Feb 2021 07:15:12 +0000 (08:15 +0100)
committerThomas Huth <thuth@redhat.com>
Fri, 19 Feb 2021 05:29:05 +0000 (06:29 +0100)
There were recently some patches on the list which had their "From:"
line mangled like this:

 From: qemu_oss--- via <qemu-devel@nongnu.org>

Since our test in the checkpatch.pl script did not trigger here, the
patches finally also ended up in a pull request, with the wrong author
set. So let's improve the regular expression to also complain on
these new patterns, too.

Message-Id: <20210216071512.1199827-1-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
scripts/checkpatch.pl

index e47ad878d8915ef2efceba1bc6b013080bcf0ac3..7f194c842bd921730e3a506b8974cb836759e2fe 100755 (executable)
@@ -1499,7 +1499,7 @@ sub process {
                        $is_patch = 1;
                }
 
-               if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) {
+               if ($line =~ /^(Author|From): .* via .*<qemu-devel\@nongnu.org>/) {
                    ERROR("Author email address is mangled by the mailing list\n" . $herecurr);
                }