virDomainDiskDef: Change type of rerror_policy to virDomainDiskErrorPolicy

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4a0358831ba76bcc46733f94422bbe93a597c261..0b12ec61f96070d37df7a60894e8c0618b48a717 100644 (file)
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -8988,12 +8988,16 @@ virDomainDiskDefDriverParseXML(virDomainDiskDef *def,
     }
     VIR_FREE(tmp);
 
-    if ((tmp = virXMLPropString(cur, "rerror_policy")) &&
-        (((def->rerror_policy = virDomainDiskErrorPolicyTypeFromString(tmp)) <= 0) ||
-         (def->rerror_policy == VIR_DOMAIN_DISK_ERROR_POLICY_ENOSPACE))) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                       _("unknown disk read error policy '%s'"), tmp);
-        return -1;
+    if ((tmp = virXMLPropString(cur, "rerror_policy"))) {
+        int rerror_policy;
+
+        if (((rerror_policy = virDomainDiskErrorPolicyTypeFromString(tmp)) <= 0) ||
+            (rerror_policy == VIR_DOMAIN_DISK_ERROR_POLICY_ENOSPACE)) {
+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                           _("unknown disk read error policy '%s'"), tmp);
+            return -1;
+        }
+        def->rerror_policy = rerror_policy;
     }
     VIR_FREE(tmp);
 

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index cacb9d0430b2b1c7851efd10c5ae63fdd497e9eb..d808f5b260d8e15e7aa2d6de8424b8c575e32452 100644 (file)
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -568,7 +568,7 @@ struct _virDomainDiskDef {
     char *product;
     virDomainDiskCache cachemode;
     virDomainDiskErrorPolicy error_policy;
-    int rerror_policy; /* enum virDomainDiskErrorPolicy */
+    virDomainDiskErrorPolicy rerror_policy;
     int iomode; /* enum virDomainDiskIo */
     virTristateSwitch ioeventfd;
     virTristateSwitch event_idx;