]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
accel/tcg: Adjust probe_access call to page_check_range
authorRichard Henderson <richard.henderson@linaro.org>
Fri, 8 May 2020 15:43:44 +0000 (08:43 -0700)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 11 May 2020 10:14:02 +0000 (11:14 +0100)
We have validated that addr+size does not cross a page boundary.
Therefore we need to validate exactly one page.  We can achieve
that passing any value 1 <= x <= size to page_check_range.

Passing 1 will simplify the next patch.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20200508154359.7494-5-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
accel/tcg/user-exec.c

index 4be78eb9b384693600dc658fcd8953d5462e26f9..03538e2a389875291bae4a7c6c19d5b94d311930 100644 (file)
@@ -211,7 +211,7 @@ void *probe_access(CPUArchState *env, target_ulong addr, int size,
         g_assert_not_reached();
     }
 
-    if (!guest_addr_valid(addr) || page_check_range(addr, size, flags) < 0) {
+    if (!guest_addr_valid(addr) || page_check_range(addr, 1, flags) < 0) {
         CPUState *cpu = env_cpu(env);
         CPUClass *cc = CPU_GET_CLASS(cpu);
         cc->tlb_fill(cpu, addr, size, access_type, MMU_USER_IDX, false,