]> xenbits.xensource.com Git - xen.git/commitdiff
libxc: avoid clobbering errno in xc_domain_pod_target()
authorJan Beulich <jbeulich@suse.com>
Tue, 4 Jan 2022 09:20:15 +0000 (10:20 +0100)
committerJan Beulich <jbeulich@suse.com>
Tue, 4 Jan 2022 09:20:15 +0000 (10:20 +0100)
do_memory_op() supplies return value and has "errno" set the usual way.
Don't overwrite "errno" with 1 (aka EPERM on at least Linux). There's
also no reason to overwrite "err".

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
tools/libs/ctrl/xc_domain.c

index 20b86d986c70c155ec68d670efc83eb918916295..ef62f66009857aefde934375b71004d2be5379d3 100644 (file)
@@ -1230,13 +1230,9 @@ static int xc_domain_pod_target(xc_interface *xch,
     err = do_memory_op(xch, op, &pod_target, sizeof(pod_target));
 
     if ( err < 0 )
-    {
         DPRINTF("Failed %s_pod_target dom %d\n",
                 (op==XENMEM_set_pod_target)?"set":"get",
                 domid);
-        errno = -err;
-        err = -1;
-    }
     else
         err = 0;