]> xenbits.xensource.com Git - qemu-upstream-4.6-testing.git/commitdiff
usb-storage: Drop not needed "allow_hotplug = 0"
authorIgor Mammedov <imammedo@redhat.com>
Fri, 26 Sep 2014 09:28:37 +0000 (09:28 +0000)
committerAndreas Färber <afaerber@suse.de>
Wed, 15 Oct 2014 03:03:14 +0000 (05:03 +0200)
Drop useless hack that disables hotplug on bus, after backend
storage was added to it, by setting "allow_hotplug = 0". Even
if bus is hotpluggable, it won't be possible to add another
SCSI device to bus since its realize will fail early with
error "no free target" in scsi_qdev_realize() method.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
hw/usb/dev-storage.c

index bccaa3fbf4a083872b06af4bcecb0facb9715bfb..b005783fdfcec58bb14c25ac56f0ca326fa55dc2 100644 (file)
@@ -632,7 +632,6 @@ static void usb_msd_realize_storage(USBDevice *dev, Error **errp)
         error_propagate(errp, err);
         return;
     }
-    s->bus.qbus.allow_hotplug = 0;
     usb_msd_handle_reset(dev);
 
     if (bdrv_key_required(bs)) {