]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: fix error propagation in qemuMigrationBegin
authorMichael Chapman <mike@very.puzzling.org>
Mon, 30 Mar 2015 02:40:59 +0000 (13:40 +1100)
committerJán Tomko <jtomko@redhat.com>
Wed, 8 Apr 2015 07:45:47 +0000 (09:45 +0200)
If virCloseCallbacksSet fails, qemuMigrationBegin must return NULL to
indicate an error occurred.

Signed-off-by: Michael Chapman <mike@very.puzzling.org>
src/qemu/qemu_migration.c

index 8c45415b7e0402e76ad0d6b0b2a04e367f0b1c60..724e3ff24b8378cbfa27b810f9b36d8a19f645b2 100644 (file)
@@ -2761,8 +2761,10 @@ qemuMigrationBegin(virConnectPtr conn,
          * place.
          */
         if (virCloseCallbacksSet(driver->closeCallbacks, vm, conn,
-                                 qemuMigrationCleanup) < 0)
+                                 qemuMigrationCleanup) < 0) {
+            VIR_FREE(xml);
             goto endjob;
+        }
         qemuMigrationJobContinue(vm);
     } else {
         goto endjob;