]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: blockjob: Don't leak 'cfg' from qemuBlockJobEventProcessLegacy
authorPeter Krempa <pkrempa@redhat.com>
Wed, 26 Jun 2019 12:52:08 +0000 (14:52 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 27 Jun 2019 11:09:54 +0000 (13:09 +0200)
Since c257352797a a reference of 'cfg' would be leaked if the function
does not need to process anything. Fix it by using VIR_AUTOUNREF.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_blockjob.c

index f105632a09d84a94990b1c9d5a947676d1b7e5d3..d7e1070c935fcc8617eff780ec80e7e96dcc12ad 100644 (file)
@@ -315,7 +315,7 @@ qemuBlockJobEventProcessLegacy(virQEMUDriverPtr driver,
                                qemuBlockJobDataPtr job,
                                int asyncJob)
 {
-    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
+    VIR_AUTOUNREF(virQEMUDriverConfigPtr) cfg = virQEMUDriverGetConfig(driver);
     virDomainDiskDefPtr disk = job->disk;
 
     VIR_DEBUG("disk=%s, mirrorState=%s, type=%d, state=%d, newstate=%d",
@@ -368,8 +368,6 @@ qemuBlockJobEventProcessLegacy(virQEMUDriverPtr driver,
             VIR_WARN("Unable to update persistent definition on vm %s "
                      "after block job", vm->def->name);
     }
-
-    virObjectUnref(cfg);
 }