]> xenbits.xensource.com Git - qemu-upstream-4.5-testing.git/commitdiff
sclp: Fix uninitialized var in handle_write_event_buf().
authorCornelia Huck <cornelia.huck@de.ibm.com>
Fri, 23 Nov 2012 00:18:12 +0000 (00:18 +0000)
committerAlexander Graf <agraf@suse.de>
Mon, 26 Nov 2012 19:16:26 +0000 (20:16 +0100)
Some gcc versions rightly complain about a possibly unitialized rc,
so let's move setting it before the QTAILQ_FOREACH().

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
hw/s390x/event-facility.c

index 93676602a7be3a0fdd996fdbe02c9340ff3a569f..bc9cea9e1b90390bfb21fea03235819d8c711c2b 100644 (file)
@@ -112,12 +112,13 @@ static uint16_t handle_write_event_buf(SCLPEventFacility *ef,
     SCLPEvent *event;
     SCLPEventClass *ec;
 
+    rc = SCLP_RC_INVALID_FUNCTION;
+
     QTAILQ_FOREACH(kid, &ef->sbus.qbus.children, sibling) {
         DeviceState *qdev = kid->child;
         event = (SCLPEvent *) qdev;
         ec = SCLP_EVENT_GET_CLASS(event);
 
-        rc = SCLP_RC_INVALID_FUNCTION;
         if (ec->write_event_data &&
             ec->event_type() == event_buf->type) {
             rc = ec->write_event_data(event, event_buf);